[fix](bucket) Raise autobucket_min_buckets default from 1 to 3#63729
Open
deardeng wants to merge 3 commits into
Open
[fix](bucket) Raise autobucket_min_buckets default from 1 to 3#63729deardeng wants to merge 3 commits into
deardeng wants to merge 3 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
/review |
Collaborator
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary: I found one blocking test-state issue. The code change itself is focused and uses the existing auto-bucket config path, but the related regression suite still restores the old default value after mutating this mutable FE config.
Critical checkpoint conclusions:
- Goal/test: The goal is to raise the auto-bucket minimum default from 1 to 3. Existing tests do not safely cover the new default because one suite resets the config back to 1.
- Scope: The code change is small and focused.
- Concurrency/lifecycle: No new concurrency or special lifecycle concerns found.
- Configuration: This changes a mutable user-visible FE config default; related tests/config reset logic must be updated.
- Compatibility/storage/transactions: No storage format, transaction, or persistence compatibility issue found for this default-only change.
- Parallel paths: Both create-table auto bucket and dynamic-partition auto bucket read Config.autobucket_min_buckets, so the changed default reaches both paths.
- Test coverage/results: Existing regression coverage has stale reset behavior and can pollute later suites.
- Observability/performance: No additional observability or performance issue found.
- User focus: No additional user-provided review focus was supplied.
Contributor
TPC-H: Total hot run time: 31532 ms |
Collaborator
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31300 ms |
Prevent the auto bucket algorithm from computing a bucket number that is too small. A minimum of 3 buckets provides a more reasonable lower bound for parallelism and data distribution under the auto bucket strategy.
Collaborator
Author
|
run buildall |
Contributor
TPC-DS: Total hot run time: 171890 ms |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
TPC-H: Total hot run time: 31500 ms |
Contributor
TPC-DS: Total hot run time: 172030 ms |
Contributor
TPC-H: Total hot run time: 31539 ms |
Contributor
TPC-DS: Total hot run time: 171381 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Collaborator
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
TPC-H: Total hot run time: 31552 ms |
Contributor
TPC-DS: Total hot run time: 172798 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Collaborator
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31588 ms |
Contributor
TPC-DS: Total hot run time: 171707 ms |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the auto bucket algorithm from computing a bucket number that is too small. A minimum of 3 buckets provides a more reasonable lower bound for parallelism and data distribution under the auto bucket strategy.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)