[fix](show variables) Fix changed variable output in show variables#63734
Open
yujun777 wants to merge 2 commits into
Open
[fix](show variables) Fix changed variable output in show variables#63734yujun777 wants to merge 2 commits into
yujun777 wants to merge 2 commits into
Conversation
SHOW VARIABLES WHERE is evaluated through an internal schema query, whose planning can temporarily set one-shot session variables and pollute the Changed column. Key changes: - Dump variables from a reverted clone for schema-scan SHOW VARIABLES requests. - Keep the existing information_schema WHERE execution path so SQL predicate behavior is preserved. - Add regression coverage for changed session variables. Unit Test: - tools/fast-compile-fe.sh LogicalPlanBuilder.java ShowVariablesCommand.java FrontendServiceImpl.java - run-regression-test.sh --run -d query_p0/ddl/show_variables -s show_variables_command
Clarify why SHOW VARIABLES dumps a reverted clone instead of cloning alone. Key changes: - Explain that setVarOnce records the origin and changes the temporary live value. - Document that only the clone is reverted before dumping variables. Unit Test: - tools/fast-compile-fe.sh FrontendServiceImpl.java
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
yujun777
changed the title
Contributor
TPC-H: Total hot run time: 31777 ms |
Contributor
TPC-DS: Total hot run time: 171341 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run feut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #0
Related PR: #
Problem Summary: SHOW VARIABLES WHERE is evaluated through an internal schema query. During planning of that internal query, FE may call setVarOnce() and temporarily change session variables such as disable_join_reorder. The schema scan then dumps those temporary values and reports them as Changed, even though they are not user-visible session changes. This patch dumps variables from a reverted clone so one-shot internal values do not affect SHOW VARIABLES output, while preserving the existing information_schema WHERE execution behavior.
Release note
Fix incorrect SHOW VARIABLES WHERE changed = 1 output caused by internal one-shot session variables.
Check List (For Author)