branch-4.1: [fix](function) fix tokenize function incorrect result when first argument is const #62699#63735
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](function) fix tokenize function incorrect result when first argument is const #62699#63735github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ument is const (#62699) ## Proposed changes Fix a bug in the `tokenize` function where `unpack_if_const` unwraps a `ColumnConst` to its inner data column (which has only 1 row), but `_do_tokenize` and `_do_tokenize_none` iterate based on the source column's row count. This causes only 1 output row to be produced instead of `input_rows_count` rows when the first argument is a constant. For example, `SELECT tokenize('hello world', 'parser=english') FROM table_with_many_rows` would previously return only 1 row instead of the expected number of rows matching the table. The fix wraps the result in `ColumnConst` when the source column was const, which is the standard pattern used throughout the Doris codebase for handling const columns in function execution. ## Further comments Related Jira: DORIS-25296 ## Checklist(Required) 1. Does it affect the results of the existing test cases (Yes/No): No 2. Does it need to update the document (Yes/No): No 3. Is there a risk of compatibility changes (Yes/No): No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62699