[fix](nereids): quote slot labels in routine-load legacy expr translation to avoid reserved-keyword parse failure#63747
Open
Baymine wants to merge 1 commit into
Open
Conversation
…tion to avoid reserved-keyword parse failure
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When a routine load job uses a column name that is a SQL reserved keyword (e.g.,
group) in a PRECEDING FILTER clause, theNereids-to-legacy expression translator sets the slot label as the raw name (e.g.,
group) without quoting. When the legacyexpression SQL is later re-parsed (e.g., during routine load reparse via
NereidsLoadUtils.parseExpressionSeq), the unquotedreserved keyword causes a parse failure, pausing the routine load job.
This PR quotes the slot label using
SqlUtils.getIdentSql()so that reserved-keyword column names are properly backtick-quoted inthe translated legacy expression SQL, preventing the parse failure.
Release note
None
Check List (For Author)
Test
Behavior changed:
toSqlWithoutTbl()output but does not affect semantics.Does this need documentation?
Check List (For Reviewer who merge this PR)