Skip to content

[fix](nereids): quote slot labels in routine-load legacy expr translation to avoid reserved-keyword parse failure#63747

Open
Baymine wants to merge 1 commit into
apache:masterfrom
Baymine:fix/quote-slot-labels-routine-load
Open

[fix](nereids): quote slot labels in routine-load legacy expr translation to avoid reserved-keyword parse failure#63747
Baymine wants to merge 1 commit into
apache:masterfrom
Baymine:fix/quote-slot-labels-routine-load

Conversation

@Baymine
Copy link
Copy Markdown
Contributor

@Baymine Baymine commented May 27, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When a routine load job uses a column name that is a SQL reserved keyword (e.g., group) in a PRECEDING FILTER clause, the
Nereids-to-legacy expression translator sets the slot label as the raw name (e.g., group) without quoting. When the legacy
expression SQL is later re-parsed (e.g., during routine load reparse via NereidsLoadUtils.parseExpressionSeq), the unquoted
reserved keyword causes a parse failure, pausing the routine load job.

This PR quotes the slot label using SqlUtils.getIdentSql() so that reserved-keyword column names are properly backtick-quoted in
the translated legacy expression SQL, preventing the parse failure.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • Yes. Slot labels in routine-load legacy expression translation are now backtick-quoted, which changes the
      toSqlWithoutTbl() output but does not affect semantics.
  • Does this need documentation?

    • No.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…tion to avoid reserved-keyword parse failure
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Baymine
Copy link
Copy Markdown
Contributor Author

Baymine commented May 27, 2026

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants