[fix](be) Cast localized filter slots for file schema types#63754
Merged
Gabriel39 merged 5 commits intoMay 27, 2026
Conversation
### What problem does this PR solve? Issue Number: close apache#63748 Problem Summary: Localized file-reader expression filters reused table slot types even when the file schema column type differed, so rewritten slot refs could read file-local blocks with the wrong type. Rewrite now uses file-local slot types and wraps a cast back to table type when needed. ### Release note None ### Check List (For Author) - Test: Unit Test - Added ColumnMapperBuildsCastFilterForTypeMismatch. Local run blocked because JAVA_HOME points to JDK 11 and JDK_17 is unset. - Behavior changed: No - Does this need documentation: No
### What problem does this PR solve? Issue Number: close apache#63748 Problem Summary: The ColumnMapper cast filter rewrite unit test used a Cast expression as the filter root, which is not a predicate. Change the test to use a UInt8 predicate expression and execute the filter path. ### Release note None ### Check List (For Author) - Test: Unit Test - Updated ColumnMapperBuildsCastFilterForTypeMismatch. Local run blocked because JAVA_HOME points to JDK 11 and JDK_17 is unset. - Behavior changed: No - Does this need documentation: No
### What problem does this PR solve? Issue Number: close apache#63748 Problem Summary: Strengthen the localized filter rewrite test to assert that mismatched file/table slot types are bridged by an inserted Cast expression before executing the predicate. ### Release note None ### Check List (For Author) - Test: Unit Test - Updated ColumnMapperBuildsCastFilterForTypeMismatch. Local run blocked because JAVA_HOME points to JDK 11 and JDK_17 is unset. - Behavior changed: No - Does this need documentation: No
### What problem does this PR solve? Issue Number: close apache#63748 Problem Summary: ColumnMapper now rebuilds projection expressions after create_scan_request assigns file-local block positions. Update the cast projection unit test to follow that lifecycle before checking the projection expression. ### Release note None ### Check List (For Author) - Test: Unit Test - Updated ColumnMapperBuildsCastProjectionForTypeMismatch. Local run blocked because JAVA_HOME points to JDK 11 and JDK_17 is unset. - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)