[fix](parquet) add missing Arrow patches for enable_force_write_int96_timestamps on branch-4.0#63762
Open
hello-stephen wants to merge 1 commit into
Conversation
…_timestamps on branch-4.0 PR apache#63597 cherry-picked the code change from master that switches from enable_deprecated_int96_timestamps() to enable_force_write_int96_timestamps(), but did not carry over the two Arrow 17.0.0 patches that introduce this new method into the thirdparty library: - apache-arrow-17.0.0-paimon.patch (prerequisite: adds the NANO unit guard) - apache-arrow-17.0.0-force-write-int96-timestamps.patch (adds the new API) Without these patches, the Arrow header only exposes enable_deprecated_int96_timestamps(), causing a compile error: error: no member named 'enable_force_write_int96_timestamps' This commit adds both patch files and registers them in download-thirdparty.sh in the correct order (paimon → force-write → status-inline-static-fix), mirroring what master already does. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #63597 cherry-picked the code change from master (via #61832) that switches
enable_deprecated_int96_timestamps()toenable_force_write_int96_timestamps()invparquet_transformer.cpp, but did not carry over the two Arrow 17.0.0 patches that introduce this new method into the thirdparty library.Without the patches, Arrow 17.0.0 only exposes
enable_deprecated_int96_timestamps(), causing a compile error:Root Cause
master has two Arrow patches that branch-4.0 was missing:
apache-arrow-17.0.0-paimon.patch— prerequisite; adds the NANO unit guard inschema.ccthat the next patch's context depends onapache-arrow-17.0.0-force-write-int96-timestamps.patch— adds theenable_force_write_int96_timestamps()API toproperties.hand the corresponding logic toschema.ccFix
Add both patch files and register them in
download-thirdparty.shin the same order as master:apache-arrow-17.0.0-paimon.patchapache-arrow-17.0.0-force-write-int96-timestamps.patchapache-arrow-17.0.0-status-inline-static-fix.patch(already present)Related
🤖 Generated with Claude Code