Skip to content

[fix](parquet) add missing Arrow patches for enable_force_write_int96_timestamps on branch-4.0#63762

Open
hello-stephen wants to merge 1 commit into
apache:branch-4.0from
hello-stephen:fix/arrow-int96-force-write-patch-branch-4.0
Open

[fix](parquet) add missing Arrow patches for enable_force_write_int96_timestamps on branch-4.0#63762
hello-stephen wants to merge 1 commit into
apache:branch-4.0from
hello-stephen:fix/arrow-int96-force-write-patch-branch-4.0

Conversation

@hello-stephen
Copy link
Copy Markdown
Contributor

Problem

PR #63597 cherry-picked the code change from master (via #61832) that switches enable_deprecated_int96_timestamps() to enable_force_write_int96_timestamps() in vparquet_transformer.cpp, but did not carry over the two Arrow 17.0.0 patches that introduce this new method into the thirdparty library.

Without the patches, Arrow 17.0.0 only exposes enable_deprecated_int96_timestamps(), causing a compile error:

error: no member named 'enable_force_write_int96_timestamps' in 'parquet::ArrowWriterProperties::Builder';
       did you mean 'enable_deprecated_int96_timestamps'?

Root Cause

master has two Arrow patches that branch-4.0 was missing:

  • apache-arrow-17.0.0-paimon.patch — prerequisite; adds the NANO unit guard in schema.cc that the next patch's context depends on
  • apache-arrow-17.0.0-force-write-int96-timestamps.patch — adds the enable_force_write_int96_timestamps() API to properties.h and the corresponding logic to schema.cc

Fix

Add both patch files and register them in download-thirdparty.sh in the same order as master:

  1. apache-arrow-17.0.0-paimon.patch
  2. apache-arrow-17.0.0-force-write-int96-timestamps.patch
  3. apache-arrow-17.0.0-status-inline-static-fix.patch (already present)

Related

🤖 Generated with Claude Code

…_timestamps on branch-4.0

PR apache#63597 cherry-picked the code change from master that switches from
enable_deprecated_int96_timestamps() to enable_force_write_int96_timestamps(),
but did not carry over the two Arrow 17.0.0 patches that introduce this new
method into the thirdparty library:
  - apache-arrow-17.0.0-paimon.patch (prerequisite: adds the NANO unit guard)
  - apache-arrow-17.0.0-force-write-int96-timestamps.patch (adds the new API)

Without these patches, the Arrow header only exposes
enable_deprecated_int96_timestamps(), causing a compile error:
  error: no member named 'enable_force_write_int96_timestamps'

This commit adds both patch files and registers them in download-thirdparty.sh
in the correct order (paimon → force-write → status-inline-static-fix),
mirroring what master already does.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hello-stephen
Copy link
Copy Markdown
Contributor Author

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant