[fix](test) Cast variant subcolumn as json in variant_hirachinal for stable output#63828
Merged
eldenmoon merged 1 commit intoMay 28, 2026
Merged
Conversation
…stable output cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Member
|
/review |
Contributor
There was a problem hiding this comment.
I found one blocking test-stability issue. The PR's goal is to remove flaky checked output caused by cast(v['c'] as string) on heterogeneous variant values, but the same suite still has an immediately preceding checked query using that exact pattern, so the regression can remain flaky under the same fuzzed session variables.
Critical checkpoints:
- Goal/test proof: The goal is to stabilize
variant_hirachinal; current change only partially accomplishes it because one checked output still uses unstable string serialization. - Scope/focus: The code change is small and focused, but incomplete for the stated failure mode.
- Concurrency/lifecycle/config/compatibility/data writes/FE-BE variable passing: Not applicable; this is a regression-test-only change.
- Parallel paths: A parallel checked query in the same suite remains unfixed.
- Test coverage/results: Existing
.outvalues are consistent with the changedjsoncasts, but coverage remains vulnerable to the same flake in the earlierqt_sql. - Observability/performance/transactions/persistence: Not applicable.
User focus points: No additional user-provided review focus was supplied.
github-actions Bot
pushed a commit
that referenced
this pull request
May 28, 2026
…stable output (#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
github-actions Bot
pushed a commit
that referenced
this pull request
May 28, 2026
…stable output (#63828) cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast(v['c'] as string) on a heterogeneous variant column can produce different whitespace formatting (e.g. "[1, 2, 3]" vs "[1,2,3]") depending on session variables fuzzed by use_fuzzy_session_variable (batch_size, enable_fold_constant_by_be, etc.), causing intermittent regression failures. Casting to json normalizes the serialization path and is stable across fuzzed execution configs (verified 50/50 runs).
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)