Skip to content

branch-3.1:[fix](user_var)fix integer typing and prefer Variable.realExpression for argument/type resolution#62524#63835

Closed
starocean999 wants to merge 2 commits into
apache:branch-3.1from
starocean999:b31_0325
Closed

branch-3.1:[fix](user_var)fix integer typing and prefer Variable.realExpression for argument/type resolution#62524#63835
starocean999 wants to merge 2 commits into
apache:branch-3.1from
starocean999:b31_0325

Conversation

@starocean999
Copy link
Copy Markdown
Contributor

@starocean999 starocean999 commented May 28, 2026 •
edited
Loading

What problem does this PR solve?

pick #62524

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@starocean999
[fix](user_var)fix integer typing and prefer Variable.realExpression …
0ee9ead 
…for argument/type resolution (apache#62524)

PR fixes two bugs:
(1) user/session variable integer typing was wrong when converted to
Nereids literals;
(2) Ensure ExpressionTrait resolves argument expressions and types from
a Variable's real expression when present, and falls back to the
Variable itself when not. This prevents generating incorrect function
signatures using Variable placeholders.
@starocean999
fix compile
a5bba8b
@starocean999 starocean999 requested a review from morrySnow as a code owner May 28, 2026 09:56
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 28, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Copy Markdown
Contributor Author

starocean999 commented May 28, 2026

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@starocean999 @hello-stephen