[refactor](be) Remove predicate column type#63839
Closed
zclllyybb wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Storage predicate reads used a dedicated PredicateColumnType and helper reader even though ordinary vectorized columns already expose the required contiguous value buffers. This change removes that intermediate representation and has fixed-width, decimal, and string predicate paths cast directly to the ordinary predicate evaluation column type and read through get_data(). ColumnString::get_data() now lazily materializes a contiguous PaddedPODArray<StringRef> view over chars/offsets, so string predicates and bloom filter evaluation keep the batch StringRef view without per-row temporary vectors. LIKE keeps the previous CHAR null-trimming semantics locally because that path intentionally used get_data_at semantics. Dictionary predicate fast paths remain unchanged.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./build.sh --be -j90
- ./run-be-ut.sh --run --filter=ColumnStringTest.get_data:ColumnStringTest.filter_by_selector:ColumnDictionaryTest.convert_to_predicate_column_if_dictionary:ColumnDictionaryTest.filter_by_selector -j90
- ./run-be-ut.sh --run --filter=ColumnNullableTest.*:BlockColumnPredicateTest.*:ColumnVectorTest.filter:ColumnDecimalTest.filter -j90
- Behavior changed: No
- Does this need documentation: No
zclllyybb
force-pushed
the
breakwater/DORIS-25930-predicate-column-type-removal
branch
from
3b2a04e to
1e4ca2b
Compare
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 32518 ms |
Contributor
TPC-DS: Total hot run time: 178575 ms |
Contributor
ClickBench: Total hot run time: 25.4 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
2 similar comments
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
Closing per DORIS-25930 request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Predicate reads in storage used a dedicated PredicateColumnType that duplicated ordinary column behavior and kept predicate evaluation on a separate column representation. This change removes that dedicated type, creates ordinary value columns for predicate reads, and adds a small storage predicate helper for typed fixed-width access and string/CHAR access where predicate evaluation still needs those raw views. It also preserves dictionary conversion through ColumnString, keeps CHAR trimming only where the previous code used get_data_at semantics such as LIKE and bloom-filter evaluation, and adds filter_by_selector support to ordinary fixed, decimal, and string columns so selected row materialization no longer depends on PredicateColumnType.
Release note
None
Check List (For Author)