Skip to content

branch-4.0: [feature](fe) Add partition filter sql block rule (#62196)#63846

Open
CalvinKirs wants to merge 2 commits into
apache:branch-4.0from
CalvinKirs:rich-branch-4.0-pr-62196
Open

branch-4.0: [feature](fe) Add partition filter sql block rule (#62196)#63846
CalvinKirs wants to merge 2 commits into
apache:branch-4.0from
CalvinKirs:rich-branch-4.0-pr-62196

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented May 28, 2026

What problem does this PR solve?

Issue Number: None

Related PR: #62196

Problem Summary: Backport the partition-filter SQL block rule changes to apache/doris branch-4.0. This recreates the PR that was accidentally opened against selectdb/selectdb-core.

Release note

Add partition-filter SQL block rule support on branch-4.0.

Check List (For Author)

  • Test: Unit Test / Manual test
    • ./run-fe-ut.sh --run org.apache.doris.nereids.rules.rewrite.PartitionPrunerTest
    • build-support/clang-format.sh
    • git diff --check
  • Behavior changed: Yes. Adds SQL block rule support for requiring partition filters.
  • Does this need documentation: No

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 61.11% (11/18) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.55% (25541/35699)
Line Coverage 54.39% (270649/497626)
Region Coverage 51.95% (224165/431488)
Branch Coverage 53.38% (96472/180732)

### What problem does this PR solve?

Issue Number: None

Related PR: apache#63846

Problem Summary: PhysicalPlanTranslatorTest reflected getPlanFragmentForPhysicalFileScan with the old three-argument signature after the helper gained table and tuple descriptor parameters, causing NoSuchMethodException in FE UT.

### Release note

None

### Check List (For Author)

- Test: Unit Test
    - env MAVEN_OPTS=-Xmx4g ./run-fe-ut.sh --run org.apache.doris.nereids.glue.translator.PhysicalPlanTranslatorTest#testNereidsFileScanCarryPartitionPredicateSignal
- Behavior changed: No
- Does this need documentation: No
@CalvinKirs
Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 54.55% (102/187) 🎉
Increment coverage report
Complete coverage report

@CalvinKirs
Copy link
Copy Markdown
Member Author

run cloud_p0

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/18) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.70% (20597/35699)
Line Coverage 40.40% (201030/497626)
Region Coverage 37.20% (160498/431488)
Branch Coverage 37.88% (68468/180732)

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants