Skip to content

[improve](nereids) filter nereidsPrunedTabletIds per partition in distributionPrune #63851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Larborator wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −5
Open

[improve](nereids) filter nereidsPrunedTabletIds per partition in distributionPrune #63851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,20 @@ private Collection<Long> distributionPrune(
DistributionInfo distributionInfo,
boolean pruneTablesByNereids) throws AnalysisException {
if (pruneTablesByNereids) {
return nereidsPrunedTabletIds.isEmpty()
? null
: new ArrayList<>(nereidsPrunedTabletIds);
if (nereidsPrunedTabletIds.isEmpty()) {
return null;
}
// Filter to tablets belonging to this partition. Without this, the caller's
// per-partition loop in computeTabletInfo becomes O(partitionNum * globalPrunedSize)
// getTablet hash lookups (most returning null), which dominates plan time
// when both partition count and pruned tablet count are large.
List<Long> result = new ArrayList<>();
for (Long id : tabletIdsInOrder) {
if (nereidsPrunedTabletIds.contains(id)) {
result.add(id);
}
}
return result;
}
DistributionPruner distributionPruner = null;
switch (distributionInfo.getType()) {
Expand Down Expand Up @@ -918,8 +929,9 @@ private void computeTabletInfo() throws UserException {
boolean notExistsSampleAndPrunedTablets = sampleTabletIds.isEmpty() && nereidsPrunedTabletIds.isEmpty();
if (prunedTabletIds != null) {
for (Long id : prunedTabletIds) {
if (selectedTable.getTablet(id) != null) {
tablets.add(selectedTable.getTablet(id));
Tablet tablet = selectedTable.getTablet(id);
if (tablet != null) {
tablets.add(tablet);
scanTabletIds.add(id);
} else if (notExistsSampleAndPrunedTablets) {
// The tabletID specified in query does not exist in this partition, skip scan partition.
Expand Down
Loading