[fix](fe) Fix SHOW TRASH ON clause to support multiple backends#63860
Open
heguanhui wants to merge 1 commit into
Open
[fix](fe) Fix SHOW TRASH ON clause to support multiple backends#63860heguanhui wants to merge 1 commit into
heguanhui wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: SHOW TRASH ON clause has two bugs:
1. The ON clause is silently ignored due to a missing return statement in
LogicalPlanBuilder.visitShowTrash(), causing SHOW TRASH ON "be:9050"
to always return trash info for all backends instead of the specified one.
2. SHOW TRASH ON only supports a single backend string literal, while
ADMIN CLEAN TRASH ON supports multiple backends with parenthesized
comma-separated list. The syntax is inconsistent between the two
related statements.
### Release note
Fix SHOW TRASH ON clause to support multiple backends with the same
syntax as ADMIN CLEAN TRASH ON, e.g. SHOW TRASH ON ("be1:9050", "be2:9050").
Previously the ON clause was silently ignored due to a missing return.
### Check List (For Author)
- Test: Regression test
- Behavior changed: Yes. SHOW TRASH ON now requires parenthesized list
syntax consistent with ADMIN CLEAN TRASH ON.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31218 ms |
Contributor
TPC-DS: Total hot run time: 172298 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: SHOW TRASH ON clause has two bugs:
LogicalPlanBuilder.visitShowTrash(), causingSHOW TRASH ON "be:9050"to always return trash info for all backends instead of the specified one.SHOW TRASH ONonly supports a single backend string literal, whileADMIN CLEAN TRASH ONsupports multiple backends with parenthesized comma-separated list. The syntax is inconsistent between the two related statements.Release note
Fix SHOW TRASH ON clause to support multiple backends with the same syntax as ADMIN CLEAN TRASH ON, e.g.
SHOW TRASH ON ("be1:9050", "be2:9050"). Previously the ON clause was silently ignored due to a missing return.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)