Skip to content

[feature](be) Add new ORC reader scaffold#63862

Draft
xylaaaaa wants to merge 1 commit into
apache:refact_reader_branchfrom
xylaaaaa:codex/new-orc-reader
Draft

[feature](be) Add new ORC reader scaffold#63862
xylaaaaa wants to merge 1 commit into
apache:refact_reader_branchfrom
xylaaaaa:codex/new-orc-reader

Conversation

@xylaaaaa
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary:

  • Add the first new-framework ORC FileReader implementation and wire FileFormat::ORC through TableReader.
  • Support basic top-level scalar ORC schema discovery, column projection, batch decoding, and EOF handling.
  • Keep filters, complex projections, and table-format-specific semantics as explicit unsupported first-version scope.

Release note

None

Check List (For Author)

  • Test:
    • Unit Test: ./run-be-ut.sh -j 12 --run --filter=NewOrcReaderTest.*:TableReaderTest.*
    • Unit Test: ./run-be-ut.sh -j 12 --run --filter=TableReaderTest.ProjectedColumnsUseMapperExpressionForSameNameDifferentIdParquetSchema
    • Format: python3 build-support/run_clang_format.py --clang-format-executable /mnt/disk1/chenjunwei/bin/clang-format --style file --inplace false --extensions c,h,C,H,cpp,hpp,cc,hh,c++,h++,cxx,hxx --exclude none be/src/format/new_orc/orc_reader.h be/src/format/new_orc/orc_reader.cpp be/src/format/reader/table_reader.cpp be/src/format/transformer/vparquet_transformer.cpp be/test/format/new_orc/orc_reader_test.cpp
    • Check: git diff --check origin/refact_reader_branch...HEAD
  • Behavior changed: No
  • Does this need documentation: No

Issue Number: None

Related PR: None

Problem Summary: Add the first new-framework ORC file reader implementation, wire it into TableReader, and cover basic schema/projection/read behavior with BE UTs. Also keep the reader column mapper strict for field-id mappings and update branch-local build fixes needed by BE UT compilation.

None

- Test: Unit Test
    - ./run-be-ut.sh -j 12 --run --filter=NewOrcReaderTest.*:TableReaderTest.*
    - python3 build-support/run_clang_format.py --clang-format-executable /mnt/disk1/chenjunwei/bin/clang-format --style file --inplace false --extensions c,h,C,H,cpp,hpp,cc,hh,c++,h++,cxx,hxx --exclude none be/src/format/new_orc/orc_reader.h be/src/format/new_orc/orc_reader.cpp be/src/format/reader/table_reader.cpp be/src/format/reader/column_mapper.cpp be/src/format/transformer/vparquet_transformer.cpp be/test/format/new_orc/orc_reader_test.cpp be/test/format/reader/table_reader_test.cpp
    - git diff --check
- Behavior changed: No
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants