[feature](be) Support parquet minmax aggregate pushdown#63868
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Gabriel39
force-pushed
the
dev_0529
branch
7 times, most recently
from
613b346 to
9723336
Compare
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Add aggregate pushdown support for the new table reader/file reader path so count and min/max can be served from parquet metadata without changing old vparquet reader, generic reader, or file scanner.
### Release note
Support count and min/max aggregate pushdown in the new table reader parquet path.
### Check List (For Author)
- Test: Unit Test
- Added TableReaderTest coverage for count, min/max, casted min/max, and Iceberg delete fallback.
- Not run locally: run-be-ut.sh requires JDK-17, but this machine has JDK-11; cmake/ninja are also unavailable.
- Behavior changed: Yes (new table reader can push down count and min/max aggregates when eligible)
- Does this need documentation: No
Gabriel39
merged commit 0ae7e1c
into
apache:refact_reader_branch
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Add a metadata-backed MIN/MAX aggregate pushdown path for external Parquet readers and gate Iceberg v2 aggregate pushdown when delete files are present.
Release note
Support min/max aggregate pushdown for eligible external Parquet scans.
Check List (For Author)
Test: Unit Test / Manual test
Added AggregateReaderTest and ParquetReaderTest.minmax_pushdown_from_statistics.
Manual test: git diff --check and git diff --cached --check.
Not run: run-be-ut.sh failed because this environment only has JDK 11 and requires JDK 17; clang-format script failed because llvm@16 is not installed.
Behavior changed: Yes, eligible Parquet scans can return min/max aggregate rows from footer statistics; unsafe Iceberg delete-file scans disable aggregate pushdown.
Does this need documentation: No
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)