Skip to content

branch-4.0: [fix](fe) Remove decimal literal debug logs #63841 #63879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
+0 −9
Open

branch-4.0: [fix](fe) Remove decimal literal debug logs #63841 #63879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...re/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DecimalV3Literal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.apache.doris.nereids.types.DecimalV3Type;

import com.google.common.base.Preconditions;
import org.apache.log4j.Logger;

import java.math.BigDecimal;
import java.math.RoundingMode;
Expand All @@ -34,8 +33,6 @@
* Literal for DecimalV3 Type
*/
public class DecimalV3Literal extends FractionalLiteral {
private static final Logger logger = Logger.getLogger(Literal.class);

private final BigDecimal value;

public DecimalV3Literal(BigDecimal value) {
Expand All @@ -57,8 +54,6 @@ public DecimalV3Literal(DecimalV3Type dataType, BigDecimal value) {
Objects.requireNonNull(value, "value not be null");
checkPrecisionAndScale(precision, scale, value);
BigDecimal adjustedValue = value.scale() < 0 ? value : value.setScale(scale, RoundingMode.HALF_UP);
logger.info("DecimalV3Literal orig bigDecimal: " + value
+ ", targetType: " + dataType + ", result big decimal: " + adjustedValue);
this.value = Objects.requireNonNull(adjustedValue);
}

Expand Down
4 changes: 0 additions & 4 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
import org.apache.doris.qe.SessionVariable;

import com.google.common.collect.ImmutableList;
import org.apache.log4j.Logger;

import java.math.BigDecimal;
import java.math.BigInteger;
Expand All @@ -70,7 +69,6 @@
*/
public abstract class Literal extends Expression implements LeafExpression {

private static final Logger logger = Logger.getLogger(Literal.class);
protected final DataType dataType;

/**
Expand Down Expand Up @@ -396,8 +394,6 @@ protected Expression getDecimalLiteral(BigDecimal bigDecimal, DataType targetTyp
}
BigDecimal result = bigDecimal.setScale(sTarget, RoundingMode.HALF_UP)
.round(new MathContext(pTarget, RoundingMode.HALF_UP));
logger.info("getDecimalLiteral orig bigDecimal: " + bigDecimal
+ ", targetType: " + targetType + ", result big decimal: " + result);
if (targetType.isDecimalV2Type()) {
return new DecimalLiteral((DecimalV2Type) targetType, result);
} else {
Expand Down
Loading