[fix](fe) Skip dropped columns in follower stats sync#63882
Open
yujun777 wants to merge 1 commit into
Open
Conversation
Follower stats sync can process queued column references after the column has been dropped, causing getColumn(...).getType() to throw a NullPointerException. Skip dropped columns before checking the type so remaining queued columns can continue to be synced. Key changes: - Check for null column metadata in FollowerColumnSender before reading the column type - Add a unit test covering dropped columns in follower stats sync Unit Test: - org.apache.doris.statistics.FollowerColumnSenderTest
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31615 ms |
Contributor
TPC-DS: Total hot run time: 171821 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run external |
1 similar comment
Contributor
Author
|
run external |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
FollowerColumnSender drains queued column references on follower FEs and syncs the columns that still need analysis to the master. A queued column can become stale after DDL changes. If the table still exists but the queued column has been dropped, table.getColumn(column.colName) returns null and the sender throws a NullPointerException while reading the type.
This patch skips dropped columns before checking the column type, so the daemon does not emit periodic ERROR logs and can continue processing the remaining queued columns.
Issue Number: close #xxx
Release note
None
Check List (For Author)