[fix](session) Reset session state for COM_RESET_CONNECTION#63884
Open
yujun777 wants to merge 1 commit into
Open
[fix](session) Reset session state for COM_RESET_CONNECTION#63884yujun777 wants to merge 1 commit into
yujun777 wants to merge 1 commit into
Conversation
COM_RESET_CONNECTION should clear session-scoped state without losing user-level default session settings such as query and insert timeout. Key changes: - Reset session variables, user variables, prepared statements, catalog/database state, running query, and return rows on COM_RESET_CONNECTION. - Reapply user default query_timeout and insert_timeout after rebuilding SessionVariable. - Add a regression helper to send COM_RESET_CONNECTION directly through the MySQL protocol. Unit Test: - ConnectContextTest - test_reset_connection_session_variable
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 31506 ms |
Contributor
TPC-DS: Total hot run time: 173055 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run nonConcurrent |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
COM_RESET_CONNECTIONonly reset the default catalog and catalog database cache, so session-scoped variables such assql_select_limitcould leak into the next logical connection when clients reused the same physical connection.What is changed?
COM_RESET_CONNECTION.query_timeoutandinsert_timeoutafter rebuildingSessionVariable.COM_RESET_CONNECTIONdirectly through the MySQL protocol.sql_select_limit = 0being cleared after reset connection.Check List
ConnectContextTesttest_reset_connection_session_variable