branch-4.1: [Fix](FoldConst) Preserve NaN in numeric constant folding #63870#63909
Merged
Conversation
Problem Summary:
Some numeric functions returned different results between normal
execution and FE constant folding when the input was NaN. The shared
boundary helper `inputOutOfBound()` treated `Double.NaN` as out of bound
because range comparisons with NaN are false, causing functions such as
`ln`, `log`, `log2`, `log10`, `dlog10`, and `power` to fold NaN cases
incorrectly to NULL or skip folding.
before
```sql
Doris> set debug_skip_fold_constant=true;
Doris> select log(2 ,cast('nan' as double));
+-------------------------------+
| log(2 ,cast('nan' as double)) |
+-------------------------------+
| NaN |
+-------------------------------+
1 row in set (0.033 sec)
Doris> set debug_skip_fold_constant=false;
Query OK, 0 rows affected (0.009 sec)
Doris> select log(2 ,cast('nan' as double));
+-------------------------------+
| log(2 ,cast('nan' as double)) |
+-------------------------------+
| NULL |
+-------------------------------+
1 row in set (0.008 sec)
```
now
```sql
Doris> set debug_skip_fold_constant=true;
Query OK, 0 rows affected (0.001 sec)
Doris> select log(2 ,cast('nan' as double));
+-------------------------------+
| log(2 ,cast('nan' as double)) |
+-------------------------------+
| NaN |
+-------------------------------+
1 row in set (0.018 sec)
Doris> set debug_skip_fold_constant=false;
Query OK, 0 rows affected (0.001 sec)
Doris> select log(2 ,cast('nan' as double));
+-------------------------------+
| log(2 ,cast('nan' as double)) |
+-------------------------------+
| NaN |
+-------------------------------+
1 row in set (0.003 sec)
```
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
skip buildall |
yiguolei
approved these changes
May 30, 2026
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63870