[Enhancement] Add human_readable_seconds function#63923
Open
prakash-atul wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Author
|
Hi @zclllyybb , the PR is ready for review. I addressed the previous review feedback and aligned the implementation with Presto/Trino semantics. I also added FE/BE unit tests, regression tests, and FE/BE consistency validation. Docs PR: apache/doris-website#3868 Thanks! |
16 tasks
Contributor
|
run buildall |
Contributor
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I found one correctness issue that should be fixed before merge. The new function is otherwise focused and well covered for normal values, nullability, constants, NaN/Inf, and FE/BE consistency around common boundaries.
Critical checkpoint conclusions:
- Goal and tests: the PR adds Presto-compatible
human_readable_seconds; normal/null/constant/folding tests are present, but out-of-range finite DOUBLE behavior is not covered. - Scope: the implementation is small and focused.
- Concurrency/lifecycle/config/transactions/persistence/data writes: not applicable; this is scalar expression evaluation only.
- Parallel code paths: FE constant folding and BE execution are both implemented, but they diverge for large finite inputs.
- Error handling: NaN/Inf are rejected, but finite values that cannot be rounded into int64 are not handled consistently.
- FE-BE protocol/type consistency: signature and return type are otherwise consistent.
- Test coverage/results: good coverage for ordinary cases; add coverage for out-of-range finite values after deciding whether to reject or clamp.
- Observability/performance: no additional observability needed; no hot-path performance concern found.
User focus: no additional user-provided review focus was specified.
prakash-atul
force-pushed
the
feature/human_readable_seconds
branch
from
f855a59 to
1c0b720
Compare
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 29417 ms |
Contributor
TPC-DS: Total hot run time: 170743 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #48203
Related PR: #61850
Problem Summary:
It adds
human_readable_seconds(double)function with behavior aligned to Presto/Trino semantics.Example:
This PR includes:
human_readable_secondstestFoldConstBehavior matches Presto/Trino:
Release note
None
Check List (For Author)
Test
Behavior changed:
human_readable_seconds(double)scalar function.Does this need documentation?
Check List (For Reviewer who merge this PR)