Skip to content

[opt](cloud) Support multiple config files in start.sh#63924

Open
gavinchou wants to merge 1 commit into
apache:masterfrom
gavinchou:opt-ms-start-conf
Open

[opt](cloud) Support multiple config files in start.sh#63924
gavinchou wants to merge 1 commit into
apache:masterfrom
gavinchou:opt-ms-start-conf

Conversation

@gavinchou
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Support loading cloud start environment variables from multiple config files without forcing deployments to rely on process_name as the only config file name.

This keeps the default behavior of loading ${process_name}.conf, and adds support for CONF_FILES with comma-separated or whitespace-separated entries, glob patterns, and absolute paths. Config files are loaded in order, later files can override earlier files, while variables already set before config loading keep priority.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: cloud/script/start.sh previously loaded only ${process_name}.conf, which made multi-instance or layered config deployments harder to express.

Release note

Support specifying multiple cloud config files through CONF_FILES in cloud/script/start.sh.

Check List (For Author)

  • Test: Manual test
    • Verified default ${process_name}.conf loading.
    • Verified comma-separated and whitespace-separated CONF_FILES lists.
    • Verified glob pattern loading.
    • Verified missing config files are skipped.
    • Verified absolute config file paths.
    • Verified pre-existing environment variables are not overridden by config files.
    • Ran bash -n cloud/script/start.sh.
  • Behavior changed: Yes. cloud/script/start.sh can now load multiple config files through CONF_FILES.
  • Does this need documentation: No

@gavinchou gavinchou requested a review from luwei16 as a code owner May 31, 2026 18:08
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Copy Markdown
Contributor Author

run buildall

@gavinchou
Copy link
Copy Markdown
Contributor Author

/review

@github-actions
Copy link
Copy Markdown
Contributor

OpenCode automated review failed and did not complete.

Error: Error: Token refresh failed: 401
Workflow run: https://github.com/apache/doris/actions/runs/26720483434

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@gavinchou
Copy link
Copy Markdown
Contributor Author

/review

@github-actions
Copy link
Copy Markdown
Contributor

OpenCode automated review failed and did not complete.

Error: Error: Token refresh failed: 401
Workflow run: https://github.com/apache/doris/actions/runs/26721256905

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants