[refactor](be)simplify interface in schema and rowcursor#63925
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
|
/review |
Contributor
|
OpenCode automated review failed and did not complete. Error: Error: Token refresh failed: 401 Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
Contributor
TPC-H: Total hot run time: 31806 ms |
Contributor
TPC-DS: Total hot run time: 172014 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed the actual GitHub PR diff (storage Schema/RowCursor constructor cleanup and associated test updates). I did not find blocking correctness issues in the changed files.
Critical checkpoint conclusions:
- Goal/test proof: the change removes unused Schema/RowCursor construction APIs and updates callers/tests to use explicit column-id vectors or field vectors; the modified tests cover the affected RowCursor/Schema use sites.
- Scope/focus: the actual PR diff is focused on BE storage schema/cursor API cleanup and related unit test updates.
- Concurrency/lifecycle: no new concurrency or shared rowset/tablet lifecycle behavior is introduced.
- Configuration/compatibility: no config, wire format, storage format, or FE/BE protocol compatibility changes are introduced by the actual PR diff.
- Parallel paths: the production seek-key path and affected test helper paths were updated consistently for the removed constructors.
- Special conditions: ROW_STORE_COL handling is preserved in the full-schema test helpers that replace the removed TabletSchema constructor usage.
- Test coverage/results: relevant BE tests were updated; I did not run them in this review environment.
- Observability/transactions/data writes: no new observability, transaction, persistence, or data-write behavior is introduced.
- Performance: removing the shared Schema reuse in TabletReader creates per-key Schema construction as before via RowCursor init; no obvious hot-path correctness issue was identified, though benchmark impact was not measured.
User focus response: no additional user-provided review focus was supplied.
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Jun 1, 2026
zhaorongsheng
pushed a commit
to zhaorongsheng/doris
that referenced
this pull request
Jun 4, 2026
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)