Skip to content

[fix](iceberg) Reject iceberg COW table row-level DML#63950

Open
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:fix_iceberg_cow
Open

[fix](iceberg) Reject iceberg COW table row-level DML#63950
hubgeter wants to merge 1 commit into
apache:masterfrom
hubgeter:fix_iceberg_cow

Conversation

@hubgeter
Copy link
Copy Markdown
Contributor

@hubgeter hubgeter commented Jun 1, 2026

What problem does this PR solve?

Problem Summary:

  1. reject iceberg cow table update/delete/merge DML(current not support)
  2. set doris create iceberg table default mode : mor

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 1, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Copy Markdown
Contributor Author

hubgeter commented Jun 1, 2026

run buildall

1 similar comment
@hubgeter
Copy link
Copy Markdown
Contributor Author

hubgeter commented Jun 1, 2026

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 1, 2026

TPC-H: Total hot run time: 29076 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e269b3fca205ce9fb927a493fc28abc9a6235057, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17712	4067	3993	3993
q2	q3	10738	1374	839	839
q4	4697	476	349	349
q5	7644	871	578	578
q6	207	168	137	137
q7	770	855	629	629
q8	10138	1744	1645	1645
q9	6894	4481	4485	4481
q10	6724	1827	1539	1539
q11	440	272	242	242
q12	637	422	285	285
q13	18110	3448	2793	2793
q14	274	268	231	231
q15	q16	826	770	711	711
q17	2385	1092	916	916
q18	6937	5719	5422	5422
q19	1490	1350	1094	1094
q20	526	586	292	292
q21	6085	2687	2592	2592
q22	478	368	308	308
Total cold run time: 103712 ms
Total hot run time: 29076 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4876	4761	4896	4761
q2	q3	4886	5285	4605	4605
q4	2126	2211	1380	1380
q5	4780	4824	4732	4732
q6	230	174	126	126
q7	1861	1864	1625	1625
q8	2416	1977	1922	1922
q9	7431	7375	7396	7375
q10	4720	4686	4223	4223
q11	537	384	350	350
q12	726	739	528	528
q13	3012	3359	2777	2777
q14	273	289	251	251
q15	q16	673	698	611	611
q17	1275	1244	1240	1240
q18	7282	6780	6779	6779
q19	1093	1083	1087	1083
q20	2222	2200	1934	1934
q21	5233	4510	4426	4426
q22	510	458	423	423
Total cold run time: 56162 ms
Total hot run time: 51151 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 1, 2026

TPC-DS: Total hot run time: 170767 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e269b3fca205ce9fb927a493fc28abc9a6235057, data reload: false

query5	4368	679	504	504
query6	328	223	206	206
query7	4263	592	300	300
query8	315	238	233	233
query9	8808	3998	3978	3978
query10	448	335	301	301
query11	5770	2359	2203	2203
query12	186	137	135	135
query13	1280	599	437	437
query14	6142	5453	5175	5175
query14_1	4478	4437	4448	4437
query15	221	210	186	186
query16	1033	481	446	446
query17	1165	753	629	629
query18	2491	500	361	361
query19	222	212	166	166
query20	149	140	132	132
query21	220	142	118	118
query22	13673	13492	13416	13416
query23	17372	16477	16182	16182
query23_1	16342	16306	16329	16306
query24	7597	1766	1306	1306
query24_1	1301	1311	1331	1311
query25	575	498	434	434
query26	1310	347	167	167
query27	2731	576	351	351
query28	4424	2026	2007	2007
query29	984	621	503	503
query30	311	226	194	194
query31	1137	1069	961	961
query32	92	80	77	77
query33	544	357	303	303
query34	1193	1115	672	672
query35	780	805	705	705
query36	1386	1433	1267	1267
query37	151	106	92	92
query38	3206	3155	3084	3084
query39	930	909	898	898
query39_1	870	881	885	881
query40	233	148	131	131
query41	66	64	62	62
query42	117	115	111	111
query43	333	335	287	287
query44	
query45	215	210	201	201
query46	1090	1198	748	748
query47	2306	2406	2251	2251
query48	400	403	291	291
query49	629	494	400	400
query50	1038	366	251	251
query51	4290	4274	4255	4255
query52	112	113	97	97
query53	268	283	214	214
query54	354	302	270	270
query55	96	94	88	88
query56	338	347	325	325
query57	1455	1456	1319	1319
query58	316	298	301	298
query59	1560	1647	1474	1474
query60	346	345	326	326
query61	187	185	190	185
query62	722	675	582	582
query63	265	204	211	204
query64	2457	862	685	685
query65	
query66	1756	505	387	387
query67	29756	29749	29568	29568
query68	
query69	474	337	300	300
query70	1053	998	1021	998
query71	310	281	268	268
query72	3056	2714	2495	2495
query73	866	795	444	444
query74	5129	4939	4734	4734
query75	2701	2614	2266	2266
query76	2345	1151	786	786
query77	407	408	341	341
query78	12266	12458	11835	11835
query79	1465	1064	786	786
query80	1337	525	475	475
query81	530	283	245	245
query82	979	156	120	120
query83	333	274	255	255
query84	267	138	110	110
query85	932	550	468	468
query86	460	340	320	320
query87	3466	3369	3230	3230
query88	3632	2781	2717	2717
query89	455	402	353	353
query90	1899	186	180	180
query91	176	164	137	137
query92	82	81	78	78
query93	1595	1437	814	814
query94	738	327	270	270
query95	697	489	360	360
query96	1053	853	341	341
query97	2761	2715	2638	2638
query98	247	237	222	222
query99	1175	1177	1037	1037
Total cold run time: 255401 ms
Total hot run time: 170767 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 1, 2026

FE Regression Coverage Report

Increment line coverage 0.00% (0/28) 🎉
Increment coverage report
Complete coverage report

@hubgeter
Copy link
Copy Markdown
Contributor Author

hubgeter commented Jun 2, 2026

run buildall

@hubgeter hubgeter mentioned this pull request Jun 2, 2026
Merged
16 tasks
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 2, 2026

FE UT Coverage Report

Increment line coverage 89.29% (25/28) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jun 2, 2026

FE Regression Coverage Report

Increment line coverage 0.00% (0/80) 🎉
Increment coverage report
Complete coverage report

yiguolei pushed a commit that referenced this pull request Jun 2, 2026
@hubgeter
branch-4.1:[fix](iceberg) Reject COW table row-level DML (#63950) (#6…
1071eef 
…3976)

### What problem does this PR solve?
Problem Summary:
pick #63950

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev/4.1.2-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hubgeter @hello-stephen @yiguolei