branch-4.0: [fix](transaction) select txn insert backend from current cluster #63634#63951
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](transaction) select txn insert backend from current cluster #63634#63951github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…3634) ### What problem does this PR solve? Problem Summary: In cloud mode with multiple compute groups, transactional `insert into values` may fail with: `Cannot invoke "org.apache.doris.system.Backend.getHost()" because "backend" is null` The root cause is that `InsertStreamTxnExecutor` selected a backend id from all clusters through `selectBackendIdsByPolicy(policy, 1)`, but then looked up the selected id from `getBackendsByCurrentCluster()`. If the selected backend belonged to another compute group, the lookup returned null and FE hit an NPE when calling `backend.getHost()`. This PR changes txn insert backend selection to use the current cluster backend snapshot as the candidate list, so the selected backend is always from the current compute group.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63634