Skip to content

[fix](be) Include parquet schema for list reader#63984

Merged
Gabriel39 merged 1 commit into
apache:refact_reader_branchfrom
Gabriel39:dev_0602
Jun 2, 2026
Merged

[fix](be) Include parquet schema for list reader#63984
Gabriel39 merged 1 commit into
apache:refact_reader_branchfrom
Gabriel39:dev_0602

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

None

  • Test: Manual test
    • Ran git diff --check and build-support/clang-format.sh for be/src/format/new_parquet/reader/list_column_reader.cpp.
  • Behavior changed: No
  • Does this need documentation: No

fix Avoid mutating blocks for equality delete keys

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Equality delete predicates evaluate child key expressions, such as casts, while filtering file blocks. Executing those children on the original file block can append intermediate columns and make TableReader block_template column count diverge from block_schema. Evaluate child keys on a temporary block so only the final delete predicate result is appended to the original block.

None

  • Test: Manual test
    • Ran git diff --check and build-support/clang-format.sh for be/src/format/reader/expr/equality_delete_predicate.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
  • Behavior changed: No
  • Does this need documentation: No

test Fix dictionary selection test expectation

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: The DictionaryPageV2StringEdgesSurviveSelection test applies a row-level StringIn conjunct with values "" and "same". Rows containing "tail" and "last" should be filtered out by that conjunct, so the expected result should include only the selected rows that satisfy the predicate.

None

  • Test: Manual test
    • Ran git diff --check and build-support/clang-format.sh for be/test/format/new_parquet/parquet_reader_test.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
  • Behavior changed: No
  • Does this need documentation: No

update

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

None

- Test: Manual test
    - Ran git diff --check and build-support/clang-format.sh for be/src/format/new_parquet/reader/list_column_reader.cpp.
- Behavior changed: No
- Does this need documentation: No

[fix](be) Avoid mutating blocks for equality delete keys

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Equality delete predicates evaluate child key expressions, such as casts, while filtering file blocks. Executing those children on the original file block can append intermediate columns and make TableReader block_template column count diverge from block_schema. Evaluate child keys on a temporary block so only the final delete predicate result is appended to the original block.

None

- Test: Manual test
    - Ran git diff --check and build-support/clang-format.sh for be/src/format/reader/expr/equality_delete_predicate.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
- Behavior changed: No
- Does this need documentation: No

[test](be) Fix dictionary selection test expectation

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: The DictionaryPageV2StringEdgesSurviveSelection test applies a row-level StringIn conjunct with values "" and "same". Rows containing "tail" and "last" should be filtered out by that conjunct, so the expected result should include only the selected rows that satisfy the predicate.

None

- Test: Manual test
    - Ran git diff --check and build-support/clang-format.sh for be/test/format/new_parquet/parquet_reader_test.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
- Behavior changed: No
- Does this need documentation: No

update
@Gabriel39 Gabriel39 merged commit 36fe40d into apache:refact_reader_branch Jun 2, 2026
12 of 14 checks passed
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants