[fix](be) Include parquet schema for list reader#63984
Merged
Merged
Conversation
None
- Test: Manual test
- Ran git diff --check and build-support/clang-format.sh for be/src/format/new_parquet/reader/list_column_reader.cpp.
- Behavior changed: No
- Does this need documentation: No
[fix](be) Avoid mutating blocks for equality delete keys
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Equality delete predicates evaluate child key expressions, such as casts, while filtering file blocks. Executing those children on the original file block can append intermediate columns and make TableReader block_template column count diverge from block_schema. Evaluate child keys on a temporary block so only the final delete predicate result is appended to the original block.
None
- Test: Manual test
- Ran git diff --check and build-support/clang-format.sh for be/src/format/reader/expr/equality_delete_predicate.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
- Behavior changed: No
- Does this need documentation: No
[test](be) Fix dictionary selection test expectation
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: The DictionaryPageV2StringEdgesSurviveSelection test applies a row-level StringIn conjunct with values "" and "same". Rows containing "tail" and "last" should be filtered out by that conjunct, so the expected result should include only the selected rows that satisfy the predicate.
None
- Test: Manual test
- Ran git diff --check and build-support/clang-format.sh for be/test/format/new_parquet/parquet_reader_test.cpp. Target BE UT could not be run locally because JAVA_HOME points to JDK 11 and JDK_17 is not set.
- Behavior changed: No
- Does this need documentation: No
update
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None
fix Avoid mutating blocks for equality delete keys
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Equality delete predicates evaluate child key expressions, such as casts, while filtering file blocks. Executing those children on the original file block can append intermediate columns and make TableReader block_template column count diverge from block_schema. Evaluate child keys on a temporary block so only the final delete predicate result is appended to the original block.
None
test Fix dictionary selection test expectation
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: The DictionaryPageV2StringEdgesSurviveSelection test applies a row-level StringIn conjunct with values "" and "same". Rows containing "tail" and "last" should be filtered out by that conjunct, so the expected result should include only the selected rows that satisfy the predicate.
None
update
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)