branch-4.1: [fix](be) Fix DCHECK in LocalExchangeSharedState::sub_total_mem_usage #63742#64014
Merged
Merged
Conversation
…#63742) Problem Summary: In LocalExchangeSharedState::sub_total_mem_usage(), `mem_usage` is `std::atomic<int64_t>` but `delta` is `size_t`. The existing debug check DCHECK_GE(prev_usage - delta, 0); was never effective: the usual arithmetic conversions promote `prev_usage - delta` to `size_t`, and an unsigned expression is trivially `>= 0`. So the guard against `mem_usage` underflow (subtracting more than was added) silently passed in all debug builds, leaving any over-subtraction undetected. Fix: compare `prev_usage` (int64_t) against `cast_set<int64_t>(delta)` so the comparison is performed entirely in signed space, and a real underflow will actually trip the DCHECK with the original prev_usage and delta values in the failure message. The release-mode guard on the next line (`cast_set<int64_t>(prev_usage - delta)` throws on underflow because the wrapped size_t result exceeds INT64_MAX) is preserved as-is.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63742