Skip to content

[improvement](be) Rewrite in predicate literals for file filters#64018

Merged
Gabriel39 merged 1 commit into
apache:refact_reader_branchfrom
Gabriel39:refa_0602
Jun 2, 2026
Merged

[improvement](be) Rewrite in predicate literals for file filters#64018
Gabriel39 merged 1 commit into
apache:refact_reader_branchfrom
Gabriel39:refa_0602

Conversation

@Gabriel39
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Extend table-to-file expression localization to rewrite IN predicate literals directly to the split file type when possible, matching the optimized binary slot-literal path. If any IN literal cannot be rewritten, restore table literals and keep the existing cast-slot fallback. Also update remaining ColumnMapping field-id test expectations.

Release note

None

Check List (For Author)

  • Test: Manual test
    • Ran build-support/clang-format.sh on touched BE files
    • Ran git diff --check and git diff --cached --check
    • Tried ./run-be-ut.sh with targeted CastTest/TableColumnMapperByIndexTest filter, but local JAVA_HOME points to JDK 11 and JDK_17 is unset
  • Behavior changed: No
  • Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: Extend table-to-file expression localization to rewrite IN predicate literals directly to the split file type when possible, matching the optimized binary slot-literal path. If any IN literal cannot be rewritten, restore table literals and keep the existing cast-slot fallback. Also update remaining ColumnMapping field-id test expectations.

### Release note

None

### Check List (For Author)

- Test: Manual test
    - Ran build-support/clang-format.sh on touched BE files
    - Ran git diff --check and git diff --cached --check
    - Tried ./run-be-ut.sh with targeted CastTest/TableColumnMapperByIndexTest filter, but local JAVA_HOME points to JDK 11 and JDK_17 is unset
- Behavior changed: No
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39 Gabriel39 merged commit fb9500a into apache:refact_reader_branch Jun 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants