[fix](test)delete unstable case qt_agg_distinct_satisfy_dst_key_with_other_func_low_ndv in agg_strategy#64022
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morrySnow
approved these changes
Jun 2, 2026
Contributor
|
run buildall |
Contributor
|
/review |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal/test: The PR removes the unstable
qt_agg_distinct_satisfy_dst_key_with_other_func_low_ndvshape-plan assertion and removes the two matching expected-output blocks for the two stats iterations. The remaining result query with the same SQL still covers correctness, while only the flaky explain-shape check is removed. - Scope: The modification is small and focused: one
qt_line and its corresponding.outsections. - Concurrency/lifecycle/config/compatibility/protocol: Not applicable; this is regression-test-only expected-output maintenance.
- Parallel code paths: The high-NDV version and other low-NDV aggregate strategy cases remain unchanged; this deletion targets only the named unstable low-NDV shape case.
- Test coverage: Coverage is reduced only for this specific shape-plan assertion. The suite still validates the query result and adjacent aggregate strategy shape cases.
- Test results: The
.outdeletion matches the removedqt_invocation and does not leave an orphan expected block for that case. - Observability/transactions/data writes/performance: Not applicable to this PR.
User focus points: no additional user-provided review focus was supplied.
englefly
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)