Skip to content

[fix](test)delete unstable case qt_agg_distinct_satisfy_dst_key_with_other_func_low_ndv in agg_strategy#64022

Merged
englefly merged 1 commit into
apache:masterfrom
feiniaofeiafei:delete_unstable_case2
Jun 3, 2026
Merged

[fix](test)delete unstable case qt_agg_distinct_satisfy_dst_key_with_other_func_low_ndv in agg_strategy#64022
englefly merged 1 commit into
apache:masterfrom
feiniaofeiafei:delete_unstable_case2

Conversation

@feiniaofeiafei
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Copy Markdown
Contributor

run buildall

@morrySnow
Copy link
Copy Markdown
Contributor

/review

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Critical checkpoint conclusions:

  • Goal/test: The PR removes the unstable qt_agg_distinct_satisfy_dst_key_with_other_func_low_ndv shape-plan assertion and removes the two matching expected-output blocks for the two stats iterations. The remaining result query with the same SQL still covers correctness, while only the flaky explain-shape check is removed.
  • Scope: The modification is small and focused: one qt_ line and its corresponding .out sections.
  • Concurrency/lifecycle/config/compatibility/protocol: Not applicable; this is regression-test-only expected-output maintenance.
  • Parallel code paths: The high-NDV version and other low-NDV aggregate strategy cases remain unchanged; this deletion targets only the named unstable low-NDV shape case.
  • Test coverage: Coverage is reduced only for this specific shape-plan assertion. The suite still validates the query result and adjacent aggregate strategy shape cases.
  • Test results: The .out deletion matches the removed qt_ invocation and does not leave an orphan expected block for that case.
  • Observability/transactions/data writes/performance: Not applicable to this PR.

User focus points: no additional user-provided review focus was supplied.

@englefly englefly merged commit f1b8e50 into apache:master Jun 3, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants