[dev](code-owner) add code owner for optimizer and mtmv#64101
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
I found one completeness issue in the CODEOWNERS update. The new rules cover optimizer/MTMV main sources, but the matching FE unit-test packages are still uncovered, so test-only changes in these areas will not request the same owners.
Critical checkpoint conclusions:
- Goal/test: The goal is to add CODEOWNERS for optimizer and MTMV. It is partially achieved for main sources and parser grammar, but not for existing FE unit-test packages. No runtime tests are needed for CODEOWNERS-only metadata.
- Scope: The change is small and focused, but incomplete for the stated ownership scope.
- Concurrency/lifecycle/config/compatibility/data correctness/transactions/observability: Not applicable; this is repository metadata only.
- Parallel paths: Main source paths were updated, but corresponding test paths were not.
- Test coverage: Not applicable to runtime behavior; local diff whitespace check passed.
User focus: No additional user-provided review focus was specified.
| fe/fe-core/src/main/java/org/apache/doris/master @mymeiyi @deardeng @gavinchou | ||
| fe/fe-core/src/main/java/org/apache/doris/mtmv @morrySnow @seawinde | ||
| fe/fe-core/src/main/java/org/apache/doris/nereids @morrySnow @924060929 @englefly @starocean999 | ||
| fe/fe-core/src/main/java/org/apache/doris/persist @mymeiyi @gavinchou |
There was a problem hiding this comment.
These new rules cover the main MTMV and Nereids source packages, but the corresponding FE unit-test packages are still uncovered: fe/fe-core/src/test/java/org/apache/doris/mtmv and fe/fe-core/src/test/java/org/apache/doris/nereids. This means a PR that only changes optimizer/MTMV tests will not request these owners, which makes the CODEOWNERS coverage incomplete for the same components. Please add matching test-directory entries near the existing fe/fe-core/src/test/java/... block.
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)