[fix](regression-test) fix stale nested-type assertions in two_level/three_level_nestedtypes_with_s3data#64706
Merged
morningman merged 1 commit intoJun 22, 2026
Conversation
…Utilization_order/two_level/three_level_nestedtypes_with_s3data GROUP BY/ORDER BY on array/map/struct columns no longer throws (CheckAfterRewrite only blocks Object/Variant/Varbinary types now), so the old "must use with specific function" exception assertions in two_level_nestedtypes_with_s3data and three_level_nestedtypes_with_s3data are stale and removed. element_at() on a struct returns an untyped result that group by/order by and functions like map_keys()/size() can't accept directly, so the most-nested-column checks now cast it to the concrete type at each point of use. Struct element_at out-of-bound access (-1/0/1000) no longer throws either, so those assertions are removed too. Also refreshes CPUNetworkUtilization_order.out to match current output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EoF4rikuEzGPKT2ML2WtnM
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
github-actions
Bot
added
the
lfs-detected!
Contributor
Author
|
skip buildall |
morningman
approved these changes
Jun 22, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
…three_level_nestedtypes_with_s3data (#64706) ## Summary - `GROUP BY`/`ORDER BY` on plain array/map/struct columns no longer throws (`CheckAfterRewrite` now only blocks Object/Variant/Varbinary types), so the old `errCode = 2 ... must use with specific function ... group by or order by` exception assertions in `two_level_nestedtypes_with_s3data.groovy` / `three_level_nestedtypes_with_s3data.groovy` are stale; removed. - `element_at()` on a struct returns an untyped result that `GROUP BY`/`ORDER BY` and functions like `map_keys()`/`size()` can't accept directly — the most-nested-column checks now `CAST` it to the concrete type at each point of use instead of relying on it implicitly resolving. - Struct `element_at()` out-of-bound access (`-1`/`0`/`1000`) no longer throws `the specified field index out of bound` either; those stale assertions are removed too. - Refreshes `CPUNetworkUtilization_order.out` (brown_p2) to match current output — same class of stale-baseline issue. ## Test plan - [x] Ran `two_level_nestedtypes_with_s3data` and `three_level_nestedtypes_with_s3data` end-to-end with `-forceGenOut` on a branch-4.0 cluster — `All suites success.` - [x] Ran both suites on a master-branch cluster — `two_level_nestedtypes_with_s3data` passes. `three_level_nestedtypes_with_s3data` hits an unrelated master-only BE bug (`[NOT_IMPLEMENTED_ERROR] Method insert_many_dict_data is not supported for TINYINT`) on a plain, untouched `element_at` SELECT — pre-existing, out of scope for this PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> https://claude.ai/code/session_01EoF4rikuEzGPKT2ML2WtnM Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
morningman
pushed a commit
that referenced
this pull request
Jun 23, 2026
…three_level_nestedtypes_with_s3data #64706 (#64709) Cherry-picked from #64706 (master). Auto cherry-pick failed with a conflict: branch-4.0's copy of these two test files still uses `struct_element()` for struct field access, while master renamed it to `element_at()` in an unrelated earlier change. Resolved by taking master's `element_at()`-based content as-is — this exact content has been run end-to-end on a real branch-4.0 cluster with `-forceGenOut` and both suites pass (`All suites success.`), confirming branch-4.0's engine supports `element_at()` on struct the same way master does. ## Summary (from #64706) - `GROUP BY`/`ORDER BY` on plain array/map/struct columns no longer throws, so the old `errCode = 2 ... must use with specific function ... group by or order by` exception assertions in `two_level_nestedtypes_with_s3data.groovy` / `three_level_nestedtypes_with_s3data.groovy` are stale; removed. - `element_at()` on a struct returns an untyped result that `GROUP BY`/`ORDER BY` and functions like `map_keys()`/`size()` can't accept directly — the most-nested-column checks now `CAST` it to the concrete type at each point of use. - Struct `element_at()` out-of-bound access (`-1`/`0`/`1000`) no longer throws `the specified field index out of bound` either; those stale assertions are removed too. - Refreshes `CPUNetworkUtilization_order.out` (brown_p2) to match current output. ## Test plan - [x] Ran both suites end-to-end with `-forceGenOut` on a real branch-4.0 cluster — `All suites success.` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> https://claude.ai/code/session_01EoF4rikuEzGPKT2ML2WtnM Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GROUP BY/ORDER BYon plain array/map/struct columns no longer throws (CheckAfterRewritenow only blocks Object/Variant/Varbinary types), so the olderrCode = 2 ... must use with specific function ... group by or order byexception assertions intwo_level_nestedtypes_with_s3data.groovy/three_level_nestedtypes_with_s3data.groovyare stale; removed.element_at()on a struct returns an untyped result thatGROUP BY/ORDER BYand functions likemap_keys()/size()can't accept directly — the most-nested-column checks nowCASTit to the concrete type at each point of use instead of relying on it implicitly resolving.element_at()out-of-bound access (-1/0/1000) no longer throwsthe specified field index out of boundeither; those stale assertions are removed too.CPUNetworkUtilization_order.out(brown_p2) to match current output — same class of stale-baseline issue.Test plan
two_level_nestedtypes_with_s3dataandthree_level_nestedtypes_with_s3dataend-to-end with-forceGenOuton a branch-4.0 cluster —All suites success.two_level_nestedtypes_with_s3datapasses.three_level_nestedtypes_with_s3datahits an unrelated master-only BE bug ([NOT_IMPLEMENTED_ERROR] Method insert_many_dict_data is not supported for TINYINT) on a plain, untouchedelement_atSELECT — pre-existing, out of scope for this PR.Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
https://claude.ai/code/session_01EoF4rikuEzGPKT2ML2WtnM