[Enhance](func) Delete useless code of split_by_char#64801
Merged
Conversation
linrrzqqq
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Part 1.3 checkpoint conclusions:
- Goal/test proof: The PR removes the Nereids-only
split_by_charwrapper and registration. This matches the stated goal because BE has nosplit_by_charimplementation, whilesplit_by_stringremains registered and covered by existing regression tests. No new runtime behavior test is necessary for deleting an unsupported FE-only symbol. - Scope/focus: The change is small and focused on the obsolete function metadata plus its visitor hook.
- Concurrency/lifecycle/config/compatibility: No concurrency, lifecycle ownership, session/config propagation, thrift/FE-BE protocol, or storage compatibility paths are touched. The compatibility-relevant observation is that the removed symbol was not executable in BE.
- Parallel paths: Current references show
split_by_string/splitremain registered in FE and BE; no remainingSplitByChar,split_by_char, orvisitSplitByCharcode path remains except an unrelated regression table name. - Tests/style: Existing split-by-string regression coverage remains in place. Scoped
git diff --checkover the PR files reported no whitespace/style issues. Full FE/regression CI was not run in this review. - Other risks: No optimizer rewrite, join/aggregate, data visibility, transaction, persistence, observability, or memory-safety behavior is changed by this deletion.
User focus: No additional user-provided review focus was supplied.
Subagent conclusions:
optimizer-rewrite: no candidates; confirmed the PR does not affect optimizer/rewrite, join, aggregate, or parallel execution paths.tests-session-config: no candidates; confirmed no regression output, session/config propagation, compatibility, or scoped style issue worth raising.- Convergence: Round 1 ended with both live subagents reporting
NO_NEW_VALUABLE_FINDINGSfor the same ledger/comment set after the final candidate update.
Overall, I found no blocking issue or inline comment to submit.
Contributor
TPC-H: Total hot run time: 28637 ms |
Contributor
TPC-DS: Total hot run time: 172469 ms |
Contributor
ClickBench: Total hot run time: 25.31 s |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Jun 25, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
### Release note
There is a function registration part for `SPLIT_BY_CHAR` in FE, but
there is no corresponding implementation in BE.
```sql
Doris> SELECT SPLIT_BY_CHAR('apple:banana:cherry', ':');
-- ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Could not find function split_by_char, arg String: String, String: String return Array(Nullable(String))
```
Since the functionality of this function has already been implemented by
`SPLIT_BY_STRING`, the implementation of this function is not meaningful
and can be directly deleted.
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 25, 2026
### Release note
There is a function registration part for `SPLIT_BY_CHAR` in FE, but
there is no corresponding implementation in BE.
```sql
Doris> SELECT SPLIT_BY_CHAR('apple:banana:cherry', ':');
-- ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]Could not find function split_by_char, arg String: String, String: String return Array(Nullable(String))
```
Since the functionality of this function has already been implemented by
`SPLIT_BY_STRING`, the implementation of this function is not meaningful
and can be directly deleted.
yiguolei
pushed a commit
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
There is a function registration part for
SPLIT_BY_CHARin FE, but there is no corresponding implementation in BE.Since the functionality of this function has already been implemented by
SPLIT_BY_STRING, the implementation of this function is not meaningful and can be directly deleted.