Skip to content

branch-4.1: [refactor](runtime-filter) remove bitmap runtime filter (#64314)#64817

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
zclllyybb:codex-pick-10704d7-branch-4.1
Jun 25, 2026
Merged

branch-4.1: [refactor](runtime-filter) remove bitmap runtime filter (#64314)#64817
yiguolei merged 1 commit into
apache:branch-4.1from
zclllyybb:codex-pick-10704d7-branch-4.1

Conversation

@zclllyybb

Copy link
Copy Markdown
Contributor

pick #64314

@zclllyybb zclllyybb requested a review from yiguolei as a code owner June 25, 2026 03:24
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Remove the obsolete bitmap runtime filter planning and execution path
while preserving thrift compatibility entries as Deprecated.

Root cause:
BITMAP_FILTER still had a dedicated FE planning branch for
bitmap-containing nested-loop join predicates and matching BE
runtime/filter predicate implementations. Even though the path is no
longer intended to be planned, helper objects and runtime mappings kept
it reachable.

Fix:
- Keep existing thrift ids and fields for BITMAP_PRED,
TRuntimeFilterType.BITMAP, bitmap_target_expr, bitmap_filter_not_in, and
is_output_left_side_only, but mark them Deprecated.
- Remove FE bitmap runtime-filter generation, pushdown, translation,
session-variable acceptance, and nested-loop join probe-only special
handling.
- Delete VBitmapPredicate, BitmapFilterFunc, and bitmap column predicate
execution objects.
- Adjust runtime-filter tests and regressions to verify bitmap runtime
filters are not planned.

(cherry picked from commit 10704d7)
@zclllyybb zclllyybb force-pushed the codex-pick-10704d7-branch-4.1 branch from ed58289 to 7c541ed Compare June 25, 2026 03:29
@zclllyybb

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.28% (1881/2434)
Line Coverage 64.31% (33742/52469)
Region Coverage 64.79% (17382/26828)
Branch Coverage 53.92% (9290/17228)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (22/22) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (35/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.74% (27472/37257)
Line Coverage 57.38% (297690/518778)
Region Coverage 54.99% (249659/454038)
Branch Coverage 56.36% (107968/191574)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 90.91% (20/22) 🎉
Increment coverage report
Complete coverage report

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei yiguolei merged commit ce28ebe into apache:branch-4.1 Jun 25, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants