[fix](fe) Serialize workload policy session updates#64833
Closed
feiniaofeiafei wants to merge 1 commit into
Closed
[fix](fe) Serialize workload policy session updates#64833feiniaofeiafei wants to merge 1 commit into
feiniaofeiafei wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: Workload policies updated a connection SessionVariable from the policy daemon while the connection thread could record or revert statement-scoped variables. Concurrent access to sessionOriginValue could throw ConcurrentModificationException, and a policy value could be overwritten by statement cleanup. Serialize session variable access for each command, apply policy updates only while the connection is idle, and explicitly exclude policy updates from statement rollback tracking.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.qe.ConnectContextTest
- mvn checkstyle:check -pl fe-core
- Behavior changed: Yes (policy session-variable updates wait for an idle connection)
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: Workload policies updated a connection SessionVariable from the policy daemon while the connection thread could record or revert statement-scoped variables. Concurrent access to sessionOriginValue could throw ConcurrentModificationException, and a policy value could be overwritten by statement cleanup. Serialize session variable access for each command, apply policy updates only while the connection is idle, and explicitly exclude policy updates from statement rollback tracking.
Release note
None
Check List (For Author)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)