Skip to content

branch-4.1: [fix](scan) Avoid misleading "storage reader" wrapper for data/expression errors #64755 #64840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Jun 26, 2026
+8 −3
Merged

branch-4.1: [fix](scan) Avoid misleading "storage reader" wrapper for data/expression errors #64755 #64840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions be/src/exec/scan/olap_scanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ Status OlapScanner::_open_impl(RuntimeState* state) {

auto res = _tablet_reader->init(_tablet_reader_params);
if (!res.ok()) {
res.append("failed to initialize storage reader. tablet=" +
std::to_string(_tablet_reader_params.tablet->tablet_id()) +
// init() also runs the eager first-row read that evaluates pushed-down expressions,
// so res may be a data/expression error rather than a storage failure. Keep its own
// message and only append the tablet/backend, without a misleading storage wording.
res.append(". tablet=" + std::to_string(_tablet_reader_params.tablet->tablet_id()) +
", backend=" + BackendOptions::get_localhost());
return res;
}
Expand Down
5 changes: 4 additions & 1 deletion ...ssion-test/suites/fault_injection_p0/test_index_compound_directory_fault_injection.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ suite("test_index_compound_directory_fault_injection", "nonConcurrent") {
res = sql "select COUNT() from ${test_index_compound_directory} where request match 'gif'"
try_sql("DROP TABLE IF EXISTS ${test_index_compound_directory}")
} catch(Exception ex) {
assertTrue(ex.toString().contains("failed to initialize storage reader"))
// _tablet_reader->init() now returns the underlying error verbatim and only
// appends the tablet/backend context (no longer the misleading
// "failed to initialize storage reader" wording).
assertTrue(ex.toString().contains("tablet=") && ex.toString().contains("backend="))
logger.info("_mock_append_data_error_in_fsindexoutput_flushBuffer, result: " + ex)
} finally {
GetDebugPoint().disableDebugPointForAllBEs("DorisFSDirectory::FSIndexOutput._mock_append_data_error_in_fsindexoutput_flushBuffer")
Expand Down
Loading