Refact reader branch#64922
Merged
Gabriel39 merged 2 commits intoJun 29, 2026
Merged
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: FileScannerV2 could not read Remote Doris Arrow Flight splits because FORMAT_ARROW was not routed to a v2 table reader and no v2-native Remote Doris reader existed. This change adds a Remote Doris TableReader/FileReader implementation for FileScannerV2 that opens Arrow Flight streams directly, builds the file-local schema from planned file slots, materializes Arrow RecordBatch data by column name into the v2 file-local block, applies localized filters through the v2 materialized-reader helper, validates protocol mismatches, and closes Flight resources. FORMAT_ARROW is enabled in FileScannerV2 only for table_format_type=remote_doris so ordinary Arrow stream files stay on the existing path.
### Release note
Support Remote Doris scans in FileScannerV2 when FileScannerV2 is enabled.
### Check List (For Author)
- Test: Manual test
- BE unit test: attempted PARALLEL=1 ./run-be-ut.sh --run --filter='FileScannerV2Test.*:RemoteDorisV2ReaderTest.*', but the sandbox could not update .git/modules/contrib/datasketches-cpp and network fallback to github.com was unavailable; escalated retries timed out in approval review.
- Manual test: python3 build-support/run_clang_format.py --clang-format-executable /usr/local/opt/llvm@16/bin/clang-format --style file --inplace false --extensions c,h,C,H,cpp,hpp,cc,hh,c++,h++,cxx,hxx --exclude none <modified files>
- Behavior changed: Yes. Remote Doris FORMAT_ARROW scan ranges can be routed to FileScannerV2.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Remote Doris file scanner v2 exposed complex slot types as top-level file columns without structural children. TableColumnMapper validates complex file schemas before building mappings, so ARRAY/MAP/STRUCT columns failed with malformed schema errors such as expected one ARRAY child but actual children was zero. This change synthesizes semantic children from the Doris slot type for Remote Doris file schema entries, using element for ARRAY, key/value for MAP, and field names for STRUCT. It also adds unit coverage for array, map, and struct schema generation.
### Release note
None
### Check List (For Author)
- Test: Unit Test / Manual test
- Added RemoteDorisV2ReaderTest.BuildsComplexSchemaChildrenFromSlots
- Ran git diff --check for the modified files
- Attempted ./run-be-ut.sh --run --filter='RemoteDorisV2ReaderTest.*' with PARALLEL=4, but the standard script could not run in the sandbox because submodule config writes were denied and the required elevated run approval timed out twice
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Gabriel39
merged commit 278e2e9
into
apache:refact_reader_branch
32 of 42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)