branch-4.0: [fix](be) prevent SIGFPE in int_divide for signed min value #64828#64947
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](be) prevent SIGFPE in int_divide for signed min value #64828#64947github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? `BIGINT_MIN DIV -1` can trigger signed integer overflow in BE `int_divide` and terminate the backend with `SIGFPE`. Root cause: `DivideIntegralImpl` only handled division by zero, but did not guard the undefined signed case where the minimal signed integer is divided by `-1`. This change follows the existing `mod`/`pmod` behavior and returns `INVALID_ARGUMENT` before executing the unsafe division. The guard covers const/const, vector/const, const/vector, and vector/vector paths. https://godbolt.org/z/YPq9W581e ### Release note None
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64828