[fix](test)fix CreateResourceCommandTest failure in cloud mode#65072
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
There was a problem hiding this comment.
Automated review summary:
No blocking issues found. I reviewed the single changed FE test file and the surrounding CreateResourceCommand / CreateResourceInfo.validate() path. The patch is limited to JMockit fixture setup for Env and SystemInfoService in CreateResourceCommandTest, and I did not find a session/config leak, mock-scope issue, optimizer/rewrite impact, or duplicate concern from existing review context.
Critical checkpoints:
- Required AGENTS.md files: none were listed for this PR.
- Existing inline review context: no existing inline comments or replies were present.
- User focus: no additional user-provided review focus.
- Whitespace/style:
git diff --check HEAD -- fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/CreateResourceCommandTest.javapassed. - Runtime validation: targeted FE test execution could not be completed in this runner because generated-source failed before tests with missing
thirdparty/installed/bin/protoc; a separate Maven attempt timed out during dependency resolution before compilation/test execution.
Subagent conclusions:
optimizer-rewrite: no candidates; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no candidates; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.- Final inline comment set: empty, so this is a summary-only review.
|
run buildall |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)