Skip to content

[fix](test) filter joined FEs in sql cache case#65098

Merged
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-parse-sql-cache-fe-filter
Jul 2, 2026
Merged

[fix](test) filter joined FEs in sql cache case#65098
hello-stephen merged 1 commit into
apache:masterfrom
shuke987:fix-parse-sql-cache-fe-filter

Conversation

@shuke987

@shuke987 shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: N/A

Problem Summary:

parse_sql_from_sql_cache.groovy has a testMultiFrontends block that should only run when at least two usable FEs are present.

In fixed-1FE P0 regression environments, SHOW FRONTENDS can still contain another FE row where Alive=true but Join=false. The previous guard only filtered by Alive, so the case could treat that non-joined row as a second FE and run the multi-FE assertions in a single joined FE topology.

This PR filters candidates with both Alive=true and Join=true, so the multi-FE block is skipped unless there are at least two joined FEs.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
      • git diff --check
      • Manual diff review: only the FE candidate filtering in parse_sql_from_sql_cache.groovy changed.
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

run buildall

@shuke987

shuke987 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

run cloud_p0

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 6fed3e1 into apache:master Jul 2, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants