branch-4.1: [fix](iceberg) Support nested decimal precision promotion #65122#65144
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Fix Iceberg complex column schema evolution validation for nested decimal precision widening. Doris validates complex column modifications before committing Iceberg schema updates. The previous nested primitive promotion rules covered varchar length growth, exact matches, integer widening, and `FLOAT -> DOUBLE`, but missed Iceberg's valid decimal promotion rule: ```text decimal(P, S) -> decimal(P', S), where P' >= P and S is unchanged ``` This patch keeps the internal table complex type schema-change path on the existing strict nested promotion rules: - integer widening - `FLOAT -> DOUBLE` Iceberg complex column schema evolution uses a separate validation entry point that additionally accepts decimal precision widening when both sides are decimal, scale is unchanged, and destination precision is not smaller. This keeps internal table nested decimal schema-change behavior unchanged. ## Why The internal table schema change matrix is broader than Iceberg schema evolution semantics. It allows conversions such as decimal bucket changes, date/string conversions, and other casts that are not safe metadata-only promotions for Iceberg nested schema evolution. ## Tests ```bash mvn test -pl fe-core -am \ -Dcheckstyle.skip=true \ -DfailIfNoTests=false \ -Dmaven.build.cache.enabled=false \ -Dtest=ColumnTest,IcebergMetadataOpsValidationTest ```
yiguolei
force-pushed
the
auto-pick-65122-branch-4.1
branch
from
46177c9 to
de258f7
Compare
Contributor
|
run buildall |
yiguolei
approved these changes
Jul 3, 2026
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by anyone and no changes requested. |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65122