[test](regression) Add warmup mixed-mode coverage and debug observabi…#65153
Open
pingchunzhang wants to merge 3 commits into
Open
[test](regression) Add warmup mixed-mode coverage and debug observabi…#65153pingchunzhang wants to merge 3 commits into
pingchunzhang wants to merge 3 commits into
Conversation
…lity ### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Add FE-side warmup diagnostics for lock blocking, periodic reschedule, and VCG-driven reconciliation paths, and add docker regression coverage for mixed warmup/VCG concurrency, conflict, failover, restart, and queue semantics. This makes the new warmup rules observable and gives regression coverage for the main mixed-mode scenarios without bringing markdown or generated artifacts into the commit. ### Release note None ### Check List (For Author) - Test: No need to test (user explicitly asked not to run FE UT/regression in this round) - Behavior changed: Yes (adds FE debug observability and new regression coverage) - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
gavinchou
previously approved these changes
Jul 2, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
pingchunzhang
commented
Jul 3, 2026
| + "createdPeriodicJobId={} createdEventJobId={} oldJobIds={}", | ||
| virtualGroupInFe.getName(), srcCg, dstCg, jobIdPeriodic, jobIdEvent, jobIdsInMs); | ||
| LOG.info("virtual compute group {}, generate new jobIds periodic={}, event={}, and old jobIds {}", | ||
| virtualGroupInFe, jobIdPeriodic, jobIdEvent, jobIdsInMs); |
Contributor
Author
There was a problem hiding this comment.
merge this two logs
| + "failureReason={}", | ||
| virtualGroupInFe.getName(), srcCg, dstCg, jobIdsInMs, e.getMessage(), e); | ||
| LOG.warn("virtual compute err, name: {}, failed to generate file cache warm up jobs: {}", | ||
| virtualGroupInFe.getName(), e.getMessage(), e); |
| + "subComputeGroups={} matchedJobIds={} cancelReason={}", | ||
| virtualComputeGroupName, activeComputeGroup, standbyComputeGroup, | ||
| subComputeGroups, matchedJobIds, cancelReason); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
remove this codes
| public boolean tryRegisterRunningJob(CloudWarmUpJob job) { | ||
| if (job.isEventDriven()) { | ||
| // Event-driven jobs do not require registration, always allow | ||
| LOG.info("warmup-lock register-skip jobId={} srcCluster={} dstCluster={} syncMode={} jobType={} " |
Contributor
Author
There was a problem hiding this comment.
use debug level
| LOG.info("Job {} skipped: waiting for job {} to finish on destination cluster {}", | ||
| jobId, existingJobId, clusterName); | ||
| if (success) { | ||
| LOG.info("warmup-lock register jobId={} srcCluster={} dstCluster={} syncMode={} jobType={} " |
Contributor
Author
There was a problem hiding this comment.
use debug level
| jobId, job.getSrcClusterName(), clusterName, job.getSyncMode(), job.getJobType(), | ||
| existingJobId, "success"); | ||
| } else { | ||
| LOG.debug("warmup-lock register jobId={} srcCluster={} dstCluster={} syncMode={} jobType={} " |
Contributor
Author
There was a problem hiding this comment.
use info level
| private boolean deregisterRunningJob(CloudWarmUpJob job) { | ||
| if (job.isEventDriven()) { | ||
| // Event-driven jobs are not registered, so nothing to deregister | ||
| LOG.info("warmup-lock deregister-skip jobId={} srcCluster={} dstCluster={} syncMode={} jobType={} " |
| if (!affectedJobIds.isEmpty()) { | ||
| LOG.info("warmup-system-cancel triggerType=CLUSTER_CHANGE clusterName={} affectedJobIds={} reason={}", | ||
| clusterName, affectedJobIds, reason); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
useless code. remove
### What problem does this PR solve? Issue Number: close apache#65153 Related PR: apache#65153 Problem Summary: The PR review pointed out duplicate warmup rebuild logs, redundant pre-scan logging before cancellation, and noisy log levels in warmup job registration. This change keeps the structured rebuild logs, removes redundant pre-scan log-only loops, and adjusts warmup lock logs to the requested debug/info levels. ### Release note None ### Check List (For Author) - Test: FE checkstyle - mvn checkstyle:check -pl fe-core - Behavior changed: No - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lity
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Add FE-side warmup diagnostics for lock blocking, periodic reschedule, and VCG-driven reconciliation paths, and add docker regression coverage for mixed warmup/VCG concurrency, conflict, failover, restart, and queue semantics. This makes the new warmup rules observable and gives regression coverage for the main mixed-mode scenarios without bringing markdown or generated artifacts into the commit.
Release note
None
Check List (For Author)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)