Skip to content

[fix](iceberg) fix doris can't select from iceberg on bos (#65170) #65171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeiPrince wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

[fix](iceberg) fix doris can't select from iceberg on bos (#65170) #65171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/fs/SchemaTypeMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ public enum SchemaTypeMapper {
HDFS("hdfs", StorageProperties.Type.HDFS, FileSystemType.HDFS, TFileType.FILE_HDFS),
LOCAL("local", StorageProperties.Type.HDFS, FileSystemType.HDFS, TFileType.FILE_HDFS),
HTTP("http", StorageProperties.Type.HTTP, FileSystemType.HTTP, TFileType.FILE_HTTP),
HTTPS("https", StorageProperties.Type.HTTP, FileSystemType.HTTP, TFileType.FILE_HTTP);
HTTPS("https", StorageProperties.Type.HTTP, FileSystemType.HTTP, TFileType.FILE_HTTP),
BOS("bos", StorageProperties.Type.S3, FileSystemType.S3, TFileType.FILE_S3);

@github-actions github-actions Bot Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the normal LocationPath/Iceberg scan path treat bos:// as S3, but the test_connection=true catalog-creation path still has its own scheme checks. ExternalCatalog.checkWhenCreating() runs CatalogConnectivityTestCoordinator; for Iceberg Glue, getTestLocation() rejects any warehouse that does not match ^(s3|s3a|s3n)://, so a bos://... Glue warehouse still fails before users reach the fixed scan path. For HMS/REST, the base tester can return the configured bos:// warehouse, but findMatchingObjectStorage() only matches s3:///s3a://, so the S3-compatible BOS storage test is skipped. Please route this path through the same SchemaTypeMapper/LocationPath normalization or add bos to the connectivity validation/matching logic, and cover a bos:// Iceberg warehouse with test_connection=true.

//LAKEFS("lakefs", StorageProperties.Type.LAKEFS),
//GCS("gs", StorageProperties.Type.S3),
//BOS("bos", StorageProperties.Type.BOS),
Expand Down
Loading