branch-4.1: [regression-test](variant) Fix schema change wait timeout #65139#65317
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [regression-test](variant) Fix schema change wait timeout #65139#65317github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? Fixes a flaky Cloud P0 failure in `variant_p0/schema_change/schema_change.groovy`. The case waits for the latest schema-change job before issuing the next ALTER. The old helper could return after timeout without observing `FINISHED`, because `useTime == OpTimeout` still passed `assertTrue(useTime <= OpTimeout)`. Then the case could run `DROP INDEX` while the table was still in `SCHEMA_CHANGE`. Remote logs from a failing run showed: - the case polled `SHOW ALTER TABLE COLUMN` for about 60s without logging `latest alter job finished` - `DROP INDEX` failed about 9s before the schema-change job actually finished - the schema-change RUNNING phase took about 69s in that run ### How is this fixed? - Increase the schema-change wait timeout from 60s to 120s. - Make the helper require an explicit `FINISHED` observation. - Include the last `SHOW ALTER TABLE COLUMN` result in the timeout failure message. ### Check - `git diff --check` No local regression rerun was performed.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65139