[refine](exec) simplify DataQueue eos handling#65324
Open
Mryange wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/review |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65324.
I did not find a substantiated blocking issue to raise inline.
Checkpoint conclusions:
- Goal and scope: the PR centralizes
DataQueueEOS handling and updates union/cache source and sink callers consistently. - Data correctness / EOS: final data blocks and empty EOS notifications are preserved through
push_block(..., eos),get_block_from_queue(), union source, and cache source. - Concurrency: multiple sink writers still use per-subqueue locks and atomics; the source-side round-robin cursor is single-reader state for the per-task
DataQueueshared state used by union/cache split pipelines. - Lifecycle:
terminate()marks children finished, clears queued/free blocks, resets the total counter, and wakes the source dependency; no new static/global lifecycle concern was found. - Config / compatibility / persistence: no new config, wire format, storage, or edit-log compatibility surface was introduced.
- Parallel paths: union pass-through/materialized paths and cache miss/hit paths were checked; no distinct missing propagation path was found.
- Tests:
DataQueueTestwas updated for EOS-only and unifiedDataQueueBlockbehavior. I attempted./run-be-ut.sh --run --filter=DataQueueTest.*, but stopped it after it expanded into third-party dependency bootstrap in this checkout, so no BE UT result is claimed.git diff --checkpassed.
Subagent conclusions:
optimizer-rewrite: no candidate findings; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: proposedTSC-001about_flag_queue_idxconcurrency. I dismissed it with code evidence because union/cacheDataQueueshared state is per source pipeline task in the reviewed split-operator wiring, leaving one source reader per queue. Convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.
User focus: no additional user-provided review focus was supplied.
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
DataQueue required callers to push data, manually mark child finish, and call remaining_has_data() to advance the internal child cursor before reading. This made eos handling spread across sink/source operators and exposed DataQueue internals to callers.
This change lets push_block() carry eos, makes get_block_from_queue() return a DataQueueBlock with the queue-level eos result, keeps per-child free lists internal to DataQueueBlock, and moves round-robin child selection into DataQueue. Union and cache operators now consume the unified queue result directly.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)