[Doris On Es] Fix assertion failure when docvalue fields is gone#6874
Closed
dh-cloud wants to merge 1 commit intoapache:masterfrom
Closed
[Doris On Es] Fix assertion failure when docvalue fields is gone#6874dh-cloud wants to merge 1 commit intoapache:masterfrom
dh-cloud wants to merge 1 commit intoapache:masterfrom
Conversation
See test case below: ```json # curl -H "Content-Type: application/json" -XPUT http://10.35.25.164:9222/test_dd?pretty -d ' { "mappings": { "_doc": { "properties": { "k1": { "type": "long" } } } } }' # curl -H "Content-Type: application/json" -XPUT http://10.35.25.164:9222/test_dd/_doc/1?pretty -d '{}' ``` In DEBUG build mode, if we read the es index, RAPIDJSON_ASSERT will be triggered because `hits.hits.fields` does not exist. ``` # curl -H "Content-Type: application/json" -XPOST '10.35.25.164:9222/test_dd/_doc/_search?filter_path=_scroll_id,hits.total,hits.hits._score,hits.hits.fields&pretty' -d '{"query":{"match_all":{}},"stored_fields":"_none_","docvalue_fields":["k1"]}' { "hits" : { "total" : 1, "hits" : [ { "_score" : null } ] } } ```
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See test case below:
In DEBUG build mode, if we read the es index, RAPIDJSON_ASSERT
will be triggered because
hits.hits.fieldsdoes not exist.Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...