Skip to content

Conversation

@morningman
Copy link
Contributor

Proposed changes

Related to PR #7459.

Implement iot_first and iot_last functions.
These are two aggregate functions that are used to implement semantics similar to the
first and last functions in influxdb.

Examples can be found in iot_first.md and iot_last.md

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added the area/sql/function Issues or PRs related to the SQL functions label Jan 3, 2022
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to extract code like below into a function

    if (ts.is_null || val.is_null) {
        return;
    }

    if (dst->is_null) {
        // first update
        _init_iot_first_last_state(context, ts, val, dst);
    } else {
        auto* dst_data = reinterpret_cast<IoTFirstLastState*>(dst->ptr);
        if (val.val > dst_data->val.val) {
            dst_data->ts = ts;
            dst_data->val = val; 
        }
    }

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jul 23, 2022
@github-actions github-actions bot closed this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql/function Issues or PRs related to the SQL functions Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants