[revert] "[improvement]upgrade-grpc-version"#8250
Merged
morningman merged 1 commit intomasterfrom Mar 2, 2022
Merged
Conversation
This reverts commit df7e848.
morningman
added
dev/backlog
Contributor
Author
|
CC @wunan1210 |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added a commit
that referenced
this pull request
Mar 14, 2022
This reverts commit df7e848. Reverts #8218 Because when using grpc 1.44.1, the corresponding `protoc-gen-grpc-java` plugin requried GLIBC_2.14, which is not found in CentOS 6. So I suggest to revert this commit this time. And considering upgrading this component after most systems have reached glibc version 2.14. And for Mac M1, you may have to change this version manually for now
morningman
added
dev/merged-1.0.1-deprecated
Closed
5 tasks
adonis0147
added a commit
that referenced
this pull request
May 11, 2023
…9522) 1. add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ 2. Remove --show-progress arguments of wget because it is not supported in low version wget 3. Downgrade grpc.version to 1.30.0 (See #8250). Co-authored-by: Mingyu Chen <morningman@163.com>
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
… (apache#19522) 1. add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ 2. Remove --show-progress arguments of wget because it is not supported in low version wget 3. Downgrade grpc.version to 1.30.0 (See apache#8250). Co-authored-by: Mingyu Chen <morningman@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8218
Because when using grpc 1.44.1, the corresponding
protoc-gen-grpc-javapluginrequried GLIBC_2.14, which is not found in CentOS 6.
So I suggest to revert this commit this time. And considering upgrading this component
after most systems have reached glibc version 2.14.
And for Mac M1, you may have to change this version manually for now