Skip to content

[fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency#8265

Merged
morningman merged 3 commits intoapache:masterfrom
morningman:insert_const
Mar 1, 2022
Merged

[fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency#8265
morningman merged 3 commits intoapache:masterfrom
morningman:insert_const

Conversation

@morningman
Copy link
Copy Markdown
Contributor

@morningman morningman commented Feb 28, 2022

Proposed changes

Issue Number: close #8264

Problem Summary:

This bug is introduced from #8112.

Also , I change the grpc-netty dependency to grpc-netty-shaded, to avoid dependency conflict:

java.lang.NoSuchMethodError: io.netty.buffer.PooledByteBufAllocator.

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (Yes)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (Yes)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/insert dev/1.0.0-deprecated should be merged into dev-1.0.0 branch labels Feb 28, 2022
EmmyMiao87
EmmyMiao87 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman changed the title [fix](chore)(insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency Feb 28, 2022
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 28, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 28, 2022

PR approved by anyone and no changes requested.

@morningman morningman merged commit 93c638f into apache:master Mar 1, 2022
morningman added a commit that referenced this pull request Mar 1, 2022
@morningman @morningman-cmy
[fix][chore](insert)(fe) Fix analysis error of insert stmt and modify…
2be9380 
… grpc-netty dependency (#8265)

This bug is introduced from #8112.

Also , I change the `grpc-netty` dependency to `grpc-netty-shaded`, to avoid dependency conflict:
```
java.lang.NoSuchMethodError: io.netty.buffer.PooledByteBufAllocator.
```
@morningman morningman added dev/merged-1.0.0-deprecated PR has been merged into dev-1.0.0 and removed dev/1.0.0-deprecated should be merged into dev-1.0.0 branch labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87 EmmyMiao87 EmmyMiao87 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/insert dev/merged-1.0.0-deprecated PR has been merged into dev-1.0.0 kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Insert into with select constants failed

2 participants

@morningman @EmmyMiao87