code cleanup#8320
Closed
dataroaring wants to merge 3 commits into
Closed
Conversation
The statements is duplicated with udf.h, and aggregate_functions.h includes udf.h
jackwener
added
the
kind/cleanup
freemandealer
added a commit
to freemandealer/doris
that referenced
this pull request
May 26, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#8320 Problem Summary: After rebasing onto latest master, FE build failed because Immutables generated FlightAuthResult code references SuppressFBWarnings but fe-core did not include the findbugs annotations artifact. Full FE UT also failed because the COS test expected constructor-time region validation although the typed S3-compatible properties now support endpoint-only configs, the authentication handler test expected an OIDC plugin that is not present in the current authentication plugin modules, the warm up job lock concurrency test relied on a main-thread static Env mock from worker threads, and java-common readable vector metadata omitted the const-column flag that its reader and meta size accounting expect. This change adds the annotation dependency for generated Immutables code, updates the COS missing-region assertion to the native presigned URL path, aligns authentication plugin manager tests with the password and LDAP plugins available on the test classpath, registers the warm up lock concurrency test Env mock inside each worker thread, and writes the const flag into vector metadata to keep writable and readable metadata layouts consistent. ### Release note None ### Check List (For Author) - Test: - ./build.sh --fe - ./run-fe-ut.sh - mvn test -pl fe-filesystem/fe-filesystem-cos -am -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false -Dtest=CosObjStorageTest - mvn test -pl fe-authentication/fe-authentication-handler -am -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false -Dtest=AuthenticationPluginManagerTest - mvn test -pl fe-core -am -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false -Dtest=org.apache.doris.cloud.cache.CacheHotspotManagerTest#testConcurrentCreateClusterOnceJobReleasesRefCountedLockAfterWaiterCompletes - mvn test -pl be-java-extensions/java-common -am -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false -Dtest=JniScannerTest - Behavior changed: No - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
code cleanup and fix wrong url.
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...