Closed
Conversation
…into support_get_metric_by_name
EmmyMiao87
reviewed
Mar 9, 2022
| std::string to_prometheus(bool with_tablet_metrics = false) const; | ||
| std::string to_json(bool with_tablet_metrics = false) const; | ||
| std::string to_core_string() const; | ||
| std::string to_json_by_name(const std::string& name, const std::string& group) const; |
Contributor
There was a problem hiding this comment.
There is no problem at the code level, but what is the main phenomenon after adding this function?
Contributor
|
We're closing this PR because it hasn't been updated in a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
add api parameter for metric name
Problem Summary:
support get metric by name(url)
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...