Skip to content

[Vectorized][Feature] support query into outfile in vec mode#8525

Closed
zhangstar333 wants to merge 1 commit intoapache:masterfrom
zhangstar333:output_file
Closed

[Vectorized][Feature] support query into outfile in vec mode#8525
zhangstar333 wants to merge 1 commit intoapache:masterfrom
zhangstar333:output_file

Conversation

@zhangstar333
Copy link
Contributor

Proposed changes

Issue Number: close #8524

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kevinjmh
Copy link
Member

kevinjmh commented May 5, 2022

hope it get fixed soon. outfile feature is not working in doris 1.0.0 and throws error "Not support send block" now

}

Status ParquetWriterWrapper::_write_one_row(vectorized::Block& block, size_t row) {
int num_columns = _output_vexpr_ctxs->size();
Copy link
Contributor

@yiguolei yiguolei May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to write a util method to convert vectorized::Block to arrow::RecordBatch, and then write to file stream block by block.
Some code could be find in be/src/util/arrow/row_block.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this implementation is based on row, the performance may not be good, so it need to be change write data by column after have another plan about vectorized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vectorized][Feature] support query into outfile in vec mode

3 participants