Replace null with empty String in master proxy result set.#8557
Merged
morningman merged 1 commit intoapache:masterfrom Mar 22, 2022
Merged
Replace null with empty String in master proxy result set.#8557morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
LGTM |
morningman
reviewed
Mar 21, 2022
| ArrayList<String> list = Lists.newArrayList(); | ||
| for (int j = 0; j < resultRows.get(i).size(); j ++) { | ||
| list.add(resultRows.get(i).get(j)); | ||
| list.add(resultRows.get(i).get(j) == null ? "" : resultRows.get(i).get(j)); |
Contributor
There was a problem hiding this comment.
Use FeConstants.null_string instead.
… fix NPE when the master proxy result set contains a null item. The NPE could cause the thrift server crash and failed to send the result back to the client which is a follower or observer fe.
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added
dev/merged-1.0.1-deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace null with empty String in master proxy result set. This is to fix NPE when the master proxy result set contains a null item. The NPE could cause the thrift server crash and fail to send the result back to the client which is a follower or an observer fe.
Problem Summary:
Suppose we have 3 follower FEs, say A, B and C. A is currently the master. If B becomes the master after A crashes, we will get the following error when we run "show frontends" command in the mysql client with connection to C:
ERROR 1105 (HY000): TTransportException, msg: Socket is closed by peer.which is caused by the thrift server side NPE (ResultSet couldn't contain null):
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...